Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Community Presets #3017

Merged
merged 18 commits into from
Mar 29, 2024
Merged

Implement Community Presets #3017

merged 18 commits into from
Mar 29, 2024

Conversation

Digitalone1
Copy link
Contributor

This is a almost complete implementation of the Community Presets #2445.

What has been done:

  • local presets are not sorted by C++ anymore (this is not needed because we already have the GtkSorter)
  • also the removal of duplicates for local presets has been removed (this was intended for multiple path, but now we have only one folder for local presets, so no need to check for duplicates)
  • added string vector properties which contains the directories where community presets may be contained (these are derived by the xdg data directories)
  • added some utils to scan the above mentioned directories in order to track the community presets
  • added an AdwStack to the presets menu popover which splits the view between the local and the community presets
  • added a ListView to the community presets stack which tracks the presets by full path, so same presets in different folders can still be seen ad different items
  • implemented an util which uses regex functions to extract the package and the preset name using the full path
  • implemented functions to load a community preset without importing it (just to test how it sounds)
  • implemented functions to import a community preset info the local path in order to be shown into the local presets list
  • SYSTEM_DIRS constants in meson.build have been removed since they were unused
  • changed the initial directory for opening dialogs; now it's the home directory (it works now and it's intended to be the starting point for importing presets/irs/models...)
  • tried to implement a GtkExpression to filter the community presets when making a search, but it's not working
  • added an overlay to show a status page in case the community presets list is empty, but it's only a draft, this has to be completed

Copy link

github-actions bot commented Mar 29, 2024

Workflow failed, but the following artifacts are still available for this pull request:


std::regex_search(preset_path.cbegin(), preset_path.cend(), name_match, re_preset_name);

return (name_match.size() == 1U) ? name_match.str(0).c_str() : "";

Check failure

Code scanning / CodeQL

Use of string after lifetime ends High

The underlying string object is destroyed after the call to 'c_str' returns.
@wwmm wwmm merged commit ad01e93 into wwmm:master Mar 29, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants