Community Presets: Implement the StatusPage #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workflow failed, but the following artifacts are still available for this pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A StatusPage is shown when the Community Presets list is empty.
I first tried with the overlay, but it was not good when the local preset list was empty because the popover was not long enough to contain the StatusPage (it was partially hidden and covering the search bar).
So I removed the overlay and now the StatusPage is a child of the StackPage. When the list is empty, the main box (search and listview) are hidden while the StatusPage is made visible.
@violetmage please test this you too, if you can. See #2445.