[master] - 'Make SonarQube happy - TT'

wwt · Dec 25, 2019 · 1260d75 · 1260d75
1 parent e756352
commit 1260d75
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 31 deletions.
diff --git a/DependencyInjection/DependencyInjected.swift b/DependencyInjection/DependencyInjected.swift
@@ -15,7 +15,7 @@ public struct DependencyInjected<Value> {
     let container:Container
 
     public init(wrappedValue value: Value?) {
-        self.name = nil
+        name = nil
         container = Workflow.defaultContainer
     }
     public init(wrappedValue value: Value? = nil, name:String) {
@@ -25,7 +25,7 @@ public struct DependencyInjected<Value> {
 
     public init(wrappedValue value: Value? = nil, container containerGetter:@autoclosure () -> Container, name:String? = nil) {
         self.name = name
-        self.container = containerGetter()
+        container = containerGetter()
     }
 
     public lazy var wrappedValue: Value? = {

diff --git a/Workflow/LinkedList/LinkedList.swift b/Workflow/LinkedList/LinkedList.swift
@@ -45,32 +45,10 @@ public class LinkedList<Value> : Sequence, CustomStringConvertible {
     /// - Complexity: O(n). The LinkedList must traverse to the end to determine the count
     public var last        : Element? { return first?.traverseToEnd() }
 
-//    /** init(arrayLiteral): A LinkedList can be instantiated with an array literal
-//     ### Example:
-//     ```swift
-//     let list:LinkedList<Int> = [1, 2, 3, 4]
-//     ```
-//    */
-//    required public convenience init(arrayLiteral elements: Value...) {
-//        self.init(elements)
-//    }
-//
-//    /** init(elements): A LinkedList can be instantiated with variadic arguments
-//     ### Example:
-//     ```swift
-//     let list = LinkedList<Int>(1, 2, 3, 4)
-//     ```
-//     */
     public convenience init(_ elements: Value...) {
         self.init(elements)
     }
-//
-//    /** init(elements): A LinkedList can be instantiated with an array
-//     ### Example:
-//     ```swift
-//     let list = LinkedList<Int>([1, 2, 3, 4])
-//     ```
-//     */
+
     public convenience init(_ elements: [Value])  {
         let collection = elements.map { Element(with: $0) }
         for (i, node) in collection.enumerated() {

diff --git a/Workflow/LinkedList/NonMutatingOperations.swift b/Workflow/LinkedList/NonMutatingOperations.swift
@@ -117,9 +117,4 @@ extension LinkedList {
         copy?.previous = nil
         return LinkedList(copy)
     }
-
-//    public func split(maxSplits: Int = Int.max, omittingEmptySubsequences: Bool = true, whereSeparator isSeparator: (Element) throws -> Bool) rethrows -> [SubSequence] {
-//        let splitNodeArr = (try? map { $0 }.split(maxSplits: maxSplits, omittingEmptySubsequences: omittingEmptySubsequences, whereSeparator: isSeparator)) ?? []
-//        return splitNodeArr.map { SubSequence($0.map { $0.value }) }
-//    }
 }
diff --git a/Workflow/Models/BasePresenter.swift b/Workflow/Models/BasePresenter.swift
@@ -10,5 +10,7 @@ import Foundation
 open class BasePresenter<T> {
     public typealias ViewType = T
 
-    required public init() { }
+    required public init() {
+        //Meant to be called from subclasses, but presenters *must* contain an empty initializer
+    }
 }