-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: how does this action handle multi-line release notes? #28
Comments
That's true, I didn't pay attention to multi-line release notes. For sure it's good idea, I will check the possibilities. Thanks for rising* this issue! |
Hi! Do you have any updates on this? :) |
hi @VladSumtsov 👋 no, sorry I didn't prioritize it - I don't have any updates on this. I'll happily welcome any PR but for now, I don't have enough time to do this myself. |
Here is how i do it :
The magic is starting with |
@sgurdag that's an interesting bit of info - does it work if you push through a multi-line string as per this issue? |
Hey @tonyarnold, Yes,It does. You can see my release note on appcenter here: It is the way of having multi-lines in YAML as it is explicitly mentioned in syntax doc here : https://docs.ansible.com/ansible/latest/reference_appendices/YAMLSyntax.html |
I'm dubious about whether this will work with a multi-line replacement like |
@tonyarnold I tested this with a multi-line replacement. See this snippet:
Unfortunately, it didn't work. Another good and clean solution to support multi-line release notes would be to provide the release notes in a file and to support the CLI parameter release-notes-file |
Update: The approach can work. It failed in my test because the release notes started with I worked around the limitation by adding a title in the YAML-config:
|
I've been calling the AppCenter CLI tool directly, and attempting to use the contents of
${{github.event.release.body}}
to populate my release notes, however it appears that I need to do some pre-processing to convert the newlines/special characters to something more appropriate for use on the command line.It doesn't look like this action does anything to help here, but I was thinking maybe it should?
Something simple to pre-process the incoming release notes text, or wrap the argument contents in a multiline argument directly would be super helpful.
The text was updated successfully, but these errors were encountered: