code quality

wznmickey · Jan 15, 2025 · 9ba744a · 9ba744a
1 parent 056c2e7
commit 9ba744a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/course.rs b/src/course.rs
@@ -130,7 +130,7 @@ impl GetFromJson<CourseFile, Rc<RefCell<Folder>>, PathBuf> for CourseFile {
         Some(CourseFile {
             id: x["id"].as_i64()?,
             my_parent_path: {
-                path.join(f.borrow().course.borrow().name.to_string())
+                path.join(&f.borrow().course.borrow().name)
                     .join(&f.borrow().fullname)
             },
             display_name: temp,
@@ -168,7 +168,7 @@ impl GetFromJson<CourseFile, Rc<RefCell<Assignment>>, PathBuf> for CourseFile {
         Some(CourseFile {
             id: x["id"].as_i64()?,
             my_parent_path: {
-                path.join(f.borrow().course.borrow().name.to_string())
+                path.join(&f.borrow().course.borrow().name)
                     .join(&f.borrow().name)
             },
             display_name: temp,

diff --git a/src/download.rs b/src/download.rs
@@ -193,7 +193,8 @@ impl RemoteData {
         path: PathBuf,
     ) -> Vec<Rc<RefCell<CourseFile>>> {
         let mut ans = Vec::new();
-        for i in assignment.borrow().filelink.clone() {
+        let filelinks = assignment.borrow().filelink.clone();
+        for i in filelinks {
             let url = i + "?"; // It is necessary to add a ?. Not sure why.
             let mut tempans = self
                 .get_remote_json_list::<Rc<RefCell<Assignment>>, PathBuf, CourseFile>(