Component specific branding #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
peteryates
force-pushed
the
component-specific-branding
branch
from
fb7e406
to
5d4c7ae
Compare
There are some components in the GOV.UK Design System that don't appear in the NHS design system. Currently teams who want to use these components need to manually copy and adjust chunks of SCSS, replacing `govuk` for `nhsuk` - a laborious process. We can make this a little easier by allowing the brand to be configured on a component-by-component basis, reducing the amount of custom styles needed. The reason this approach was taken and not just passing in a `brand` override to each component is that there's no easy way of passing arguments through to the slots without converting them all to lambdas[0]. This will likely be a really niche feature. [0] https://viewcomponent.org/guide/slots.html#lambda-slots
peteryates
force-pushed
the
component-specific-branding
branch
from
5d4c7ae
to
a31e241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some components in the GOV.UK Design System that don't appear in the NHS design system. Currently teams who want to use these components need to manually copy and adjust chunks of SCSS, replacing
govukfornhsuk- a laborious process.We can make this a little easier by allowing the brand to be configured on a component-by-component basis, reducing the amount of custom styles needed.
The reason this approach was taken and not just passing in a
brandoverride to each component is that there's no easy way of passing arguments through to the slots without converting them all to lambdas.This will likely be a really niche feature.
Fixes #547