Certain functions lack input validation routines.md

23 - Certain functions lack input validation routines

The functions should first check if the passed arguments are valid first. These checks should include, but not be limited to:

1. uint should be larger than 0 when 0 is considered invalid
2. uint should be within constraints
3. int should be positive in some cases
4. length of arrays should match if more arrays are sent as arguments
5. addresses should not be 0x0

Recommendation:

Add tests that check if all of the arguments have been validated. Consider checking arguments as an important part of writing code and developing the system.

---

Slide Screenshot

---

Slide Text

• ConsenSys Audit Shell Protocol Finding 6.2
• Input Validation
• Major Severity
• Parameter Checks
• Valid/Threshold/o/+ve
• Add Checks Testing

---

References

• Youtube Reference
• Major severity finding from Consensys Diligence Audit of Shell Protocol

---

Tags