Optimize Import Time by Deferring SSL Context Creation #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dosine-staging[bot]](https://avatars.githubusercontent.com/in/697727?s=60&v=4){kind=small}
Co-authored-by: Genie <genie@cosine.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue of increased import time caused by the changes in psf#6667. The primary change involves deferring the creation of the SSL context until it is actually needed, rather than at import time. This optimization should help reduce the import time by avoiding the expensive
load_verify_locations()call during the initial import.Changes:
get_ssl_contextfunction.get_ssl_contextthat creates and caches the SSL context. This function ensures that the SSL context is only created once per interpreter instance, thus optimizing the import time.These changes should help mitigate the import time regression observed between versions 2.31.0 and 2.32.3.