Optimize import time by deferring SSL context creation #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dosine-staging[bot]](https://avatars.githubusercontent.com/in/697727?s=60&v=4){kind=small}
Co-authored-by: Genie <genie@cosine.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the import time regression issue identified between versions 2.31.0 and 2.32.3 of the library. The regression was caused by the
load_verify_locations()function being executed at import time, as introduced in PR psf#6667.Changes Made:
_get_preloaded_ssl_context(), which is called only when needed, rather than at import time._urllib3_request_contextfunction to use the new_get_preloaded_ssl_context()method, ensuring that the SSL context is only created when required.These changes should reduce the import time by deferring the expensive SSL context creation until it is actually needed, thus resolving the regression issue.
Testing:
To verify the improvement, compare the import times of the affected versions using the provided reproduction steps. This should demonstrate a reduction in import time back to levels similar to version 2.31.0.