Upgrade binskim and fix an error in nuget packaging pipeline (microso…

…ft#17340) ### Description Upgrade binskim and fix an error in nuget packaging pipeline.
xadupre · Aug 30, 2023 · 71da082 · 71da082
1 parent 21ae86e
commit 71da082
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/tools/ci_build/github/azure-pipelines/templates/c-api-linux-cpu.yml b/tools/ci_build/github/azure-pipelines/templates/c-api-linux-cpu.yml
@@ -19,6 +19,9 @@ parameters:
 
 - name: OnnxruntimeNodejsBindingArch
   type: string
+  values:
+  - arm64
+  - x64
 
 - name: PoolName
   type: string

diff --git a/tools/ci_build/github/azure-pipelines/templates/compliance.yml b/tools/ci_build/github/azure-pipelines/templates/compliance.yml
@@ -12,10 +12,10 @@ steps:
     debugMode: false
   continueOnError: true
 
-- task: BinSkim@3
+- task: BinSkim@4
   displayName: 'Run BinSkim'
   inputs:
-    arguments: 'analyze $(Build.BinariesDirectory)\RelWithDebInfo\RelWithDebInfo\*.dll  --recurse --verbose'
+    AnalyzeTargetGlob: '+:file|$(Build.ArtifactStagingDirectory)\**\*.dll;-:file|$(Build.ArtifactStagingDirectory)\**\DirectML.dll'
   continueOnError: true
 
 - task: DeleteFiles@1

diff --git a/tools/ci_build/github/azure-pipelines/templates/linux-gpu-tensorrt-packaging-pipeline.yml b/tools/ci_build/github/azure-pipelines/templates/linux-gpu-tensorrt-packaging-pipeline.yml
@@ -23,6 +23,9 @@ parameters:
   type: string
   default: ''
 
+# We only have CUDA/TRT on x64. We do not have a build for CUDA/TRT for ARM64.
+# Therefore this file does not have an `OnnxruntimeNodejsBindingArch` parameter
+
 stages:
 - stage: Linux_C_API_Packaging_GPU_TensorRT_x64
   dependsOn: []
@@ -70,7 +73,7 @@ stages:
       - ${{ if eq(parameters.buildNodejs, 'true') }}:
           - template: nodejs-artifacts-package-and-publish-steps-posix.yml
             parameters:
-              arch: '${{parameters.OnnxruntimeNodejsBindingArch}}'
+              arch: 'x64'
               os: 'linux'
               artifactName: 'drop-onnxruntime-nodejs-linux-x64-tensorrt'