Skip to content

Commit

Permalink
lint c++
Browse files Browse the repository at this point in the history
  • Loading branch information
xadupre committed Sep 1, 2023
1 parent 55b06ea commit db31126
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions onnxruntime/contrib_ops/cuda/math/gemm_float8.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include "core/providers/cuda/shared_inc/fpgeneric.h"
#include "core/providers/cpu/math/gemm_helper.h"
#include "gemm_float8.h"
#include <string>

using namespace ONNX_NAMESPACE;

Expand Down
3 changes: 2 additions & 1 deletion onnxruntime/contrib_ops/cuda/math/gemm_float8.cu
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "core/providers/cuda/cu_inc/common.cuh"
#include "core/providers/cuda/shared_inc/cuda_utils.h"
#include <algorithm>
#include <utility>
#include <cuda_runtime.h>

namespace onnxruntime {
Expand Down Expand Up @@ -379,7 +380,7 @@ Status GemmFloat8::ComputeGemm(
// The workspace should be allocated once from OpKernelContext assuming
// only one cuda function is running at a time (which is not necessarily true
// with H100).
size_t workspaceSize = (size_t)(1 << 25); // suggested fixed value 32Mb
size_t workspaceSize = static_cast<size_t>(1 << 25); // suggested fixed value 32Mb
cublasLtMatmulPreference_t preference = nullptr;
cublasLtMatmulPreferenceCreate(&preference);
cublasLtMatmulPreferenceSetAttribute(preference,
Expand Down
2 changes: 1 addition & 1 deletion onnxruntime/contrib_ops/cuda/math/gemm_float8.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class GemmFloat8 final : public onnxruntime::cuda::CudaKernel {
cublasComputeType_t compute_type_;
cublasLtEpilogue_t epilogue_;

// TODO: add epilogue (= activation function, Relu or Gelu are available).
// TODO(xadupre): add epilogue (= activation function, Relu or Gelu are available).
};

} // namespace cuda
Expand Down

0 comments on commit db31126

Please sign in to comment.