Better documentation, remove IsInvalidType

xadupre · Jul 5, 2023 · feb398c · feb398c
1 parent 4f99fd5
commit feb398c
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 11 deletions.
diff --git a/include/onnxruntime/core/framework/data_types.h b/include/onnxruntime/core/framework/data_types.h
@@ -141,10 +141,6 @@ class DataTypeImpl {
     return type_ == GeneralType::kNonTensor;
   }
 
-  bool IsInvalidType() const {
-    return type_ == GeneralType::kInvalid;
-  }
-
   bool IsPrimitiveDataType() const {
     return type_ == GeneralType::kPrimitive;
   }

diff --git a/include/onnxruntime/core/framework/ort_value.h b/include/onnxruntime/core/framework/ort_value.h
@@ -75,10 +75,6 @@ struct OrtValue {
 #endif
   }
 
-  bool IsInvalid() const noexcept {
-    return (type_ != nullptr && type_->IsInvalidType());
-  }
-
   onnxruntime::MLDataType Type() const {
     return type_;
   }

diff --git a/include/onnxruntime/core/session/onnxruntime_cxx_api.h b/include/onnxruntime/core/session/onnxruntime_cxx_api.h
@@ -213,6 +213,7 @@ static_assert(sizeof(BFloat16_t) == sizeof(uint16_t), "Sizes must match");
 /** \brief float8e4m3fn (Float8 Floating Point) data type
  * \details It is necessary for type dispatching to make use of C++ API
  * The type is implicitly convertible to/from uint8_t.
+ * See https://onnx.ai/onnx/technical/float8.html for further details.
  */
 struct Float8E4M3FN_t {
   uint8_t value;
@@ -229,6 +230,7 @@ static_assert(sizeof(Float8E4M3FN_t) == sizeof(uint8_t), "Sizes must match");
 /** \brief float8e4m3fnuz (Float8 Floating Point) data type
  * \details It is necessary for type dispatching to make use of C++ API
  * The type is implicitly convertible to/from uint8_t.
+ * See https://onnx.ai/onnx/technical/float8.html for further details.
  */
 struct Float8E4M3FNUZ_t {
   uint8_t value;
@@ -245,6 +247,7 @@ static_assert(sizeof(Float8E4M3FNUZ_t) == sizeof(uint8_t), "Sizes must match");
 /** \brief float8e5m2 (Float8 Floating Point) data type
  * \details It is necessary for type dispatching to make use of C++ API
  * The type is implicitly convertible to/from uint8_t.
+ * See https://onnx.ai/onnx/technical/float8.html for further details.
  */
 struct Float8E5M2_t {
   uint8_t value;
@@ -261,6 +264,7 @@ static_assert(sizeof(Float8E5M2_t) == sizeof(uint8_t), "Sizes must match");
 /** \brief float8e5m2fnuz (Float8 Floating Point) data type
  * \details It is necessary for type dispatching to make use of C++ API
  * The type is implicitly convertible to/from uint8_t.
+ * See https://onnx.ai/onnx/technical/float8.html for further details.
  */
 struct Float8E5M2FNUZ_t {
   uint8_t value;

diff --git a/onnxruntime/core/providers/shared_library/provider_interfaces.h b/onnxruntime/core/providers/shared_library/provider_interfaces.h
@@ -586,7 +586,6 @@ struct ProviderHost {
 #if !defined(DISABLE_SPARSE_TENSORS)
   virtual bool DataTypeImpl__IsSparseTensorType(const DataTypeImpl* p) = 0;
 #endif
-  virtual bool DataTypeImpl__IsInvalidType(const DataTypeImpl* p) = 0;
 
   virtual DeleteFunc DataTypeImpl__GetDeleteFunc(const DataTypeImpl* p) = 0;
 

diff --git a/onnxruntime/core/providers/shared_library/provider_wrappedtypes.h b/onnxruntime/core/providers/shared_library/provider_wrappedtypes.h
@@ -544,7 +544,6 @@ class DataTypeImpl final {
 #if !defined(DISABLE_SPARSE_TENSORS)
   bool IsSparseTensorType() const { return g_host->DataTypeImpl__IsSparseTensorType(this); }
 #endif
-  bool IsInvalidType() const { return g_host->DataTypeImpl__IsInvalidType(this); }
 
   DeleteFunc GetDeleteFunc() const { return g_host->DataTypeImpl__GetDeleteFunc(this); }
 

diff --git a/onnxruntime/core/session/provider_bridge_ort.cc b/onnxruntime/core/session/provider_bridge_ort.cc
@@ -691,7 +691,6 @@ struct ProviderHostImpl : ProviderHost {
 #if !defined(DISABLE_SPARSE_TENSORS)
   bool DataTypeImpl__IsSparseTensorType(const DataTypeImpl* p) override { return p->IsSparseTensorType(); }
 #endif
-  bool DataTypeImpl__IsInvalidType(const DataTypeImpl* p) override { return p->IsInvalidType(); }
 
   DeleteFunc DataTypeImpl__GetDeleteFunc(const DataTypeImpl* p) override { return p->GetDeleteFunc(); }