Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Enabling Code Sign Validation through 1ES template #95

Closed
wants to merge 4 commits into from

Conversation

MSLukeWest
Copy link

@MSLukeWest MSLukeWest commented Oct 7, 2024

Description

Enabling code signing validation in the main merq pipeline through the 1ES pipeline template.

See https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/sdlanalysis/codesignvalidation

As part of this I'm getting rid of the "symbols" artifact, as it was collecting the unsigned assemblies. I also noticed the upload step wasn't actually doing anything, so I removed it.

Part of task https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2268473

PR Checklist

  • Title is meaningful

  • Work Item is linked

  • Changes are described

  • Tests

    • Automated tests are added
    • OR
    • Infrastructure
    • OR
    • Upcoming sprint Work Item:
    • OR
    • Test exception

@MSLukeWest MSLukeWest self-assigned this Oct 7, 2024
@MSLukeWest MSLukeWest marked this pull request as ready for review October 17, 2024 19:00
@MSLukeWest MSLukeWest requested review from mauroa, emaf, tondat and a team as code owners October 17, 2024 19:00
@emaf
Copy link

emaf commented Oct 17, 2024

@MSLukeWest main will no longer receive updates as we are removing this component from VS.

@MSLukeWest
Copy link
Author

@MSLukeWest main will no longer receive updates as we are removing this component from VS.

Right. I'll close this, and we can port it to older branches later if necessary.

@MSLukeWest MSLukeWest closed this Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants