Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix missing partial columns in horizontal grid layout #6241

Merged
merged 8 commits into from
Jun 17, 2019
Merged

Conversation

hartez
Copy link
Contributor

@hartez hartez commented May 21, 2019

Description of Change

These changes work around a UICollectionViewFlowLayout issue where horizontally-scrolling grid layouts do not display the last column if it is only partial.

These changes also fix an issue where the CollectionView does not respect the Page's safe area settings on iOS 11+ (which had a side-effect of incorrectly laying out columns in landscape mode).

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Issue 6077 in Control Gallery (automated).

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
  • Boxes checked

@rmarinho
Copy link
Member

/azp help

@azure-pipelines
Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or a specific pipeline for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify a pipeline to run.
    • Example: "run" or "run pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@rmarinho
Copy link
Member

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@rmarinho
Copy link
Member

/azp where

@azure-pipelines
Copy link

Azure DevOps orgs getting events for this repository:

@samhouts samhouts changed the base branch from master to 4.1.0 May 29, 2019 19:17
Copy link
Member

@samhouts samhouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hartez Test fails on Android :(

@hartez
Copy link
Contributor Author

hartez commented Jun 17, 2019

Failing iOS tests are utterly unrelated.

@samhouts samhouts self-requested a review June 17, 2019 18:20
@samhouts samhouts merged commit 9eb3161 into 4.1.0 Jun 17, 2019
@samhouts samhouts deleted the fix-gh6077 branch June 17, 2019 21:07
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jun 18, 2019
@samhouts samhouts added this to the 4.1.0 milestone Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/collectionview approved Has two approvals, no pending reviews, and no changes requested p/iOS 🍎 t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants