This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fix missing partial columns in horizontal grid layout #6241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp help |
Supported commands
See additional documentation. |
/azp list |
CI/CD Pipelines for this repository: |
/azp where |
Azure DevOps orgs getting events for this repository: |
paymicro
approved these changes
May 30, 2019
samhouts
suggested changes
Jun 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hartez Test fails on Android :(
…fixes #6077 Fix content inset behaviors when dealing with safe area on newer iOS versions
Failing iOS tests are utterly unrelated. |
samhouts
approved these changes
Jun 17, 2019
samhouts
added
the
approved
Has two approvals, no pending reviews, and no changes requested
label
Jun 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a/collectionview
approved
Has two approvals, no pending reviews, and no changes requested
p/iOS 🍎
t/bug 🐛
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
These changes work around a UICollectionViewFlowLayout issue where horizontally-scrolling grid layouts do not display the last column if it is only partial.
These changes also fix an issue where the CollectionView does not respect the Page's safe area settings on iOS 11+ (which had a side-effect of incorrectly laying out columns in landscape mode).
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Issue 6077 in Control Gallery (automated).
PR Checklist