Lower the needed UWP Version #1709
Replies: 3 comments 1 reply
-
We ultimately need to make a decision on this topic to give you an answer and prevent you from having to keep these PRs up to date without anything happening. The following documents my thoughts on this as I try to point out the positives and negatives of these proposed changes. I am also fairly new to this team/project so please forgive me if I have missed any details. Some initial pointsAs documented here
Weighing things upPositives
Negatives
SummaryThis is a difficult one to make a decision on! I currently feel that the team does not have any extra bandwidth to take on more effort but of course this is just my opinion and this is an open discussion but in argument to that if community members have put the effort in to testing this and proven it behaves then I don't see that there should be too much effort in the short term to take one of the PRs. Worst case should things start to break we could reverse out the change and move to a more modern minimum version. @inforithmics you have clearly put some effort in to creating the PRs, how confident are you that this won't break things in terms of other functionality provided by the toolkit? |
Beta Was this translation helpful? Give feedback.
-
The pull request that lowers the Target to 1903 ist certainly the lowest Risk. Because it ist only one framework Version and has not many changes. It is what I currently use. And it only needs to be Tested once. And I don't think that this could introduce breaking changes. The other pull request ist much riskier because I needed to Change Code by conditional compiling. So this needs to be Tested two times. Maybe a bit much for a Target that ist not used so much. And in Maui this isn't needed anymore. |
Beta Was this translation helpful? Give feedback.
-
So in conclusion I'm pretty confident that #1247 won't break anything. The other pullrequest I'm not so sure about. |
Beta Was this translation helpful? Give feedback.
-
When Popup functionality was added to Xamarin Community Toolkit. The UWP Version was raised from 10.0.17763 (1809) To 10.0.19041(2004)
Because I need to support at least Version 1903 some others need to support 1809 Because 1809 is a Windows LTS Release I cannot use an official Xamarin.Community.Toolkit package greater than Version 1.0.3.
I Have made 3 Pull request to adresse this Problem.
Lower the UWP Version to the lowest Version that supports all used features.
#1684
This is the smallest Pull request, it simply lowers the UWP Version to 18382 (1903) (There all Flyout features that are used are
present for Popup).
Reintroduce the UWP Version 17763 / 1809
#1247
This pull request adds an additional Target with the Version 17763 / 1809 and handles the some things that are not available on 1809 differently than the 10.0.19041(2004) Target.
#942
This pull request lowers down the Target to 17763 / 1809 and uses UWP features to detect if a feature is availble on the Target machine.
So I wanted to discuss here how Xamarin Community Toolkit should progress here. Because MAUI is available at the earlist in Spring 2022.
When there is no interest in integrating one of the 3 Pull Requests into Xamarin Community Toolkit. Than I will keep them open to get the newest Xamarin Community Toolkit packages With this specified fixes.
Beta Was this translation helpful? Give feedback.
All reactions