Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for weird jitter of motion blur texture if onscreen raindrops are rendering? #2

Open
TorutheRedFox opened this issue Mar 17, 2022 · 5 comments

Comments

@TorutheRedFox
Copy link

it's very likely a vanilla bug, but it still should be fixed

@TorutheRedFox
Copy link
Author

(fyi it's jitter of DIFFUSEMAP_TEXTURE in motionblur technique, seems it's being set weirdly?)

@xan1242
Copy link
Owner

xan1242 commented Mar 23, 2022

Sorry for late reply, just catching up.

Do you have an example of it? (recording of some kind?) I'm having a hard time noticing exactly what you mean. It seems to work fine for me, although I'm running my game with VSync most of the time.

It's very likely the game renderer itself is buggy, not the shader. For this we'd need to figure out the location of both passes in the code (motion blur and onscreen raindrop) and try to eliminate which one is the cause.

It should be relatively easy to figure out what is the cause, but finding the solution is gonna take a bit of tinkering.

@TorutheRedFox
Copy link
Author

here https://pastebin.com/8xuDNRxR

the vanilla game uses a different texture, but that's blurred already

@xan1242
Copy link
Owner

xan1242 commented Mar 23, 2022

I'll test it out, thanks!

@xan1242
Copy link
Owner

xan1242 commented Mar 23, 2022

I'm sorry but this looks to be purely your shader's fault, not a game bug.

As far as I can tell, the shader you've shared with me is based on Most Wanted 360, which uses a different rendering technique to Carbon for motion blurring found here.

The structures are differently arranged and the image is never taken from DIFFUSEMAP_TEXTURE, only from MOTIONBLUR_TEXTURE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants