-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a genkitx evaluator plugin - Promptfoo #14
Conversation
WalkthroughThe pull request introduces a structural update to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
README.md (2)
Line range hint
25-36
: Update the table of contents to include the new "Evaluator Plugins" section.The new "Evaluator Plugins" section added to the document is not reflected in the table of contents. To maintain consistency and improve navigation, please update the "Contents" section to include the new "Evaluator Plugins" entry.
Consider adding the following line to the "Contents" section:
## Contents <!-- omit from toc --> - [Plugins](#plugins) - [JavaScript - Official](#javascript---official) - [JavaScript - Community](#javascript---community) + - [Evaluator Plugins](#evaluator-plugins) - [Golang - Official](#golang---official) - [Golang - Community](#golang---community) - [Talks](#talks)
89-91
: LGTM! Consider adding a brief description for the new plugin.The addition of the "Evaluator Plugins" subsection and the
genkitx-promptfoo
plugin is well-organized and consistent with the PR objectives. Great job on improving the structure of the document!To maintain consistency with other plugin entries, consider adding a brief description of the
genkitx-promptfoo
plugin. For example:3. Evaluator Plugins - - [`genkitx-promptfoo`](https://github.com/yukinagae/genkitx-promptfoo) - Plugin for Promptfoo Evaluations. + - [`genkitx-promptfoo`](https://github.com/yukinagae/genkitx-promptfoo) - Plugin for Promptfoo Evaluations. Integrates Promptfoo assertions into the Genkit framework for enhanced evaluation processes.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (1 hunks)
Additional comments not posted (1)
README.md (1)
Line range hint
1-368
: Overall, the changes improve the document structure and content.The addition of the "Evaluator Plugins" section and the
genkitx-promptfoo
plugin entry enhances the organization of the README.md file. The changes are consistent with the PR objectives and contribute positively to the curated list of Firebase Genkit resources.Two minor suggestions were made to further improve the document:
- Update the table of contents to include the new "Evaluator Plugins" section.
- Add a brief description for the
genkitx-promptfoo
plugin to maintain consistency with other entries.These small adjustments will ensure the document remains well-structured and informative for users exploring Firebase Genkit resources.
Describe The changes
This change is a:
[] Bug fix
[x] New awesome stuff
[] Documentation update
[] Other
Added a evaluator plugin, genkitx-promptfoo.
It utilizes Promptfoo assertions within Genkit to enhance the evaluation processes.
Like this pull request? Vote for it by adding a 👍
Summary by CodeRabbit
New Features
genkitx-promptfoo
plugin specifically for Promptfoo Evaluations.Documentation