feat: added new models #63
Conversation
WalkthroughThe pull request introduces several new AI model references and updates existing ones in the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (4)
src/index.ts (1)
51-52: LGTM! Consider maintaining alphabetical order.The exports are properly grouped by model family (Llama, Cohere, Microsoft) which aids readability. However, consider maintaining alphabetical order within each group for consistency.
metaLlama318bInstruct, + metaLlama3290bVisionInstruct, metaLlama3211bVisionInstruct, - metaLlama3290bVisionInstruct, cohereCommandRPlus, cohereCommandR, - cohereCommandR082024, - cohereCommandRPlus082024, + cohereCommandR082024, + cohereCommandRPlus082024,Also applies to: 55-56, 69-69
src/github_llms.ts (3)
Line range hint
240-286: Fix model name and version inconsistencies in Cohere models.There are configuration issues in the new Cohere models:
cohereCommandRPlus082024has incorrect name property- Version strings are inconsistent with naming convention
Apply these fixes:
export const cohereCommandR082024 = modelRef({ name: "github/cohere-command-r", info: { - versions: ["Cohere-command-r-08-2024"], + versions: ["cohere-command-r-08-2024"], label: "Cohere - Command-r-08-2024", // ... } }); export const cohereCommandRPlus082024 = modelRef({ - name: "github/cohere-command-r", + name: "github/cohere-command-r-plus", info: { - versions: ["Cohere-command-r-plus-08-2024"], + versions: ["cohere-command-r-plus-08-2024"], label: "Cohere - Command-r-plus-08-2024", // ... } });
Line range hint
465-494: Update label to match new model name convention.The label for
microsoftPhi35Mini128kInstructstill contains "128k" despite the name change in the model identifier and version.Apply this fix:
export const microsoftPhi35Mini128kInstruct = modelRef({ name: "github/phi-3.5-mini-instruct", info: { versions: ["Phi-3.5-mini-instruct"], - label: "Microsoft - Phi-3.5-mini-128k-instruct", + label: "Microsoft - Phi-3.5-mini-instruct", // ... } });
Line range hint
506-524: Update model keys to match version strings.The keys in SUPPORTED_GITHUB_MODELS should match the version strings defined in the model configurations for consistency.
Apply these fixes:
export const SUPPORTED_GITHUB_MODELS: Record<string, any> = { // ... - "Llama-3.2-11B-Vision-Instruct": metaLlama3211bVisionInstruct, - "Llama-3.2-90B-Vision-Instruct": metaLlama3290bVisionInstruct, + "meta-llama-3.2-11b-vision-instruct": metaLlama3211bVisionInstruct, + "meta-llama-3.2-90b-vision-instruct": metaLlama3290bVisionInstruct, "cohere-command-r": cohereCommandR, "cohere-command-r-plus": cohereCommandRPlus, - "cohere-command-r-08-2024": cohereCommandR082024, - "cohere-command-r-plus-08-2024": cohereCommandRPlus082024, + "cohere-command-r-08-2024": cohereCommandR082024, + "cohere-command-r-plus-08-2024": cohereCommandRPlus082024, // ... "Phi-3.5-mini-instruct": microsoftPhi35Mini128kInstruct, "Phi-3.5-moe-instruct": microsoftPhi35MoE128kInstruct, };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- src/github_llms.ts (7 hunks)
- src/index.ts (3 hunks)
🧰 Additional context used
🔇 Additional comments (1)
src/index.ts (1)
4-4: LGTM! Verify model definitions exist.The new model imports align with the PR objectives for adding llama vision and cohere models.
✅ Verification successful
Let me try a different approach to verify the model definitions.
This should help us verify:
- The existence of model definitions using a more flexible pattern
- The actual content of the github_llms.ts file to ensure it exists and contains the expected exports
All imported models are properly defined and exported
After reviewing the github_llms.ts file, I can confirm that all the imported models are properly defined:
microsoftPhi35MoE128kInstructis defined with proper configuration and exportedcohereCommandR082024andcohereCommandRPlus082024are defined with proper configurations and exportedmetaLlama3211bVisionInstructandmetaLlama3290bVisionInstructare defined with proper configurations and exported, with vision capabilities enabled (media: true)All models are also correctly registered in the
SUPPORTED_GITHUB_MODELSrecord for use in the system.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that all imported models are properly defined in github_llms.ts ast-grep --pattern 'export const $MODEL = { $$$ }' | rg -A 5 'microsoftPhi35MoE128kInstruct|cohereCommandR082024|cohereCommandRPlus082024|metaLlama3211bVisionInstruct|metaLlama3290bVisionInstruct'Length of output: 200
Script:
#!/bin/bash # Search for model definitions using ripgrep directly rg -U "export const (microsoftPhi35MoE128kInstruct|cohereCommandR082024|cohereCommandRPlus082024|metaLlama3211bVisionInstruct|metaLlama3290bVisionInstruct)\s*=\s*{[^}]*}" --type ts # Also check if the file exists and show its content fd "github_llms.ts" --type f --exec cat {}Length of output: 22500
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Before you submit a pull request, please make sure you have read and understood the contribution guidelines and the code of conduct.
This pull request is related to:
I have checked the following:
Description:
Fix llama models, Phi models and added new llama vision models + new cohere models
Summary by CodeRabbit
New Features
metaLlama3211bVisionInstruct,metaLlama3290bVisionInstruct,cohereCommandR082024,cohereCommandRPlus082024, andmicrosoftPhi35MoE128kInstruct, enhancing multiturn interactions and media capabilities.Bug Fixes
Documentation