ET-4885 allow to prefix snippets #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustonaut
commented
Nov 14, 2023
web-api/src/embedding.rs
Outdated
| }; | ||
|
|
||
| let sequence = if let Some(prefix) = prefix { | ||
| Cow::Owned(format!("{prefix} {sequence}")) |
There was a problem hiding this comment.
Is the concatenation using a space okay?
acrrd
approved these changes
Nov 14, 2023
web-api/src/embedding.rs
Outdated
| #[cfg_attr(test, serde(deny_unknown_fields))] | ||
| pub(crate) struct Prefix { | ||
| /// Prefix prepended to search queries when embedding them. | ||
| pub(crate) query: Option<String>, |
There was a problem hiding this comment.
I am not sure if we care to distinguish between prefix not given and an empty prefix. The end result will be the same.
There was a problem hiding this comment.
If you by default separate the prefix with a white-space from the rest it makes a difference.
Through we removed the default space separator so I now changed it to empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows specifying two prefixes:
embedding.prefix.queryprefix all queries with this before computing their embeddingembedding.prefix.snippetprefix all snippets with this before computing their embeddingworks for both local and sagemaker setups
Env variables:
XAYN_WEB_API__EMBEDDING__PREFIX__QUERYXAYN_WEB_API__EMBEDDING__PREFIX__SNIPPET