Remove obsolete migration test #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the deploy we have pass that migration point so this test is useless. Pointing to our version in the past increase the compilation time for the tests by 30s. This also create problem with cargo chef that is not able to handle a self dependency on an older version.
x3ro
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the deployments we have are after the migration point we are checking here so this test is useless.
Pointing to our version in the past increases the compilation time for the tests by 30s and brings in a lot of older dependencies.
This also creates a problem with cargo-chef that cannot handle a dependency with different versions (see next PR).