Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service.subtitles.opensubtitles-com] 1.0.4 #2579

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

opensubtitlesdev
Copy link

Description

Multiple fixes on file path, language submitted by user "pannal" opensubtitlesdev/service.subtitles.opensubtitles-com
Improvements of the error messages for the user

Checklist:

* [x ] My code follows the [add-on rules](http://kodi.wiki/view/Add-on_rules) and [piracy stance](http://kodi.wiki/view/Official:Forum_rules#Piracy_Policy) of this project.

* [ x] I have read the [CONTRIBUTING](https://github.com/xbmc/repo-scripts/blob/master/CONTRIBUTING.md) document

* [ x] Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

* Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.

* [add-on development](http://kodi.wiki/view/Add-on_development) wiki page.

* Kodi [pydocs](http://kodi.wiki/view/PyDocs) provide information about the Python API

* [PEP8](https://www.python.org/dev/peps/pep-0008/) codingstyle which is considered best practise but not mandatory.

* This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at [Codacy](https://www.codacy.com/app/Kodi/repo-scripts/dashboard). You can create your own account as well to continuously monitor your python coding before submitting to repo.

* Development questions can be asked in the [add-on development](http://forum.kodi.tv/forumdisplay.php?fid=26) section on the Kodi forum.

@opensubtitlesdev
Copy link
Author

spending so much time answering support tickets for bugs solved by this release... please merge it...

@romanvm
Copy link
Collaborator

romanvm commented Jan 21, 2024

Please fix one minor issue

@opensubtitlesdev
Copy link
Author

ok, fixed, added a last minute little change in the data collection that caused errors with streamed movies
opensubtitlesdev/service.subtitles.opensubtitles-com#20

@romanvm romanvm added Approved Approved and is ready to merge and removed waiting for developer to respond labels Jan 29, 2024
@opensubtitlesdev
Copy link
Author

Please fix one minor issue

yes it's done, please, what else can I do to speed up the process ?

@romanvm romanvm merged commit 21a0218 into xbmc:matrix Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants