Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile based on present architecture #127

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

semi-h
Copy link
Member

@semi-h semi-h commented Oct 8, 2024

No description provided.

@semi-h semi-h requested a review from Nanoseb October 8, 2024 11:11
Copy link
Collaborator

@Nanoseb Nanoseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, lgtm. I won't have to add it manually

@semi-h
Copy link
Member Author

semi-h commented Oct 8, 2024

Do we need similar options in the tests/CmakeLists.txt as well or the ones in src/CmakeLists.txt is used by default there? @Nanoseb

@Nanoseb
Copy link
Collaborator

Nanoseb commented Oct 8, 2024

hum, actually none of the flags in that line are picked up by cmake it seems. Let me double check

@Nanoseb
Copy link
Collaborator

Nanoseb commented Oct 8, 2024

(but changing them directly in cmake also propagates it for the tests, so that part is fine)

@Nanoseb
Copy link
Collaborator

Nanoseb commented Oct 8, 2024

Because these variables are internal ones defined already by cmake they had to be overwritten and a test had to be added so that users could still use ccmake or anything else to edit them.

@semi-h
Copy link
Member Author

semi-h commented Oct 8, 2024

I've tried locally and all good for me, but the GitHub action failed here in the PR, do you have any idea why?

@Nanoseb
Copy link
Collaborator

Nanoseb commented Oct 8, 2024

do we know which version of cmake the CI uses? it doesn't seem to detect openmp related things properly. This isn't something that was introduced with this PR but flags set here never got actually used before so we see it only now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants