-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Runge-Kutta time-integration schemes #94
Merged
JamieJQuinn
merged 11 commits into
xcompact3d:main
from
CFD-Xing:update-time-integration-rk
Jun 25, 2024
Merged
Add Runge-Kutta time-integration schemes #94
JamieJQuinn
merged 11 commits into
xcompact3d:main
from
CFD-Xing:update-time-integration-rk
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFD-Xing
commented
May 17, 2024
CFD-Xing
commented
May 17, 2024
@CFD-Xing can you do a rebase please? It'll help for reviewing the RK related stuff. |
CFD-Xing
commented
May 21, 2024
CFD-Xing
commented
May 21, 2024
CFD-Xing
commented
May 21, 2024
CFD-Xing
commented
May 21, 2024
semi-h
reviewed
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Runge-Kutta schemes from order 1 to 4.
The default time-stepping approach is set to AB3.
All schemes (AB1 to AB4 and RK1 to RK4) have been validated for the Dahlquist equation.
For the TGV case, this PR has been tested with RK3 with the following result
TODO: