Skip to content

Commit

Permalink
removed notebook-run from tests, and added todo and explanation
Browse files Browse the repository at this point in the history
  • Loading branch information
thomasstorm committed Jun 17, 2024
1 parent 126286f commit a02ff48
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,13 @@ env:
# Unfortunately, you cannot set an if statement on job level. Hence, these variables are used in each step
# of a unittest/nb-test job.
RUN_UNITTESTS: "1"
RUN_NB_TESTS: "1"
# todo - switch the notebook tests back on after xcube-hub has been replaced
# Currently, the notebooks under test use xcube-hub, which uses an HS256 key to
# authenticate at PostGREST. The switch from xcube-hub to a Keycloak-based solution
# enforces the use of an RS256 key. Therefore, dev-PostGREST is already configured
# with an RS256 key, but as we do not want to change xcube-hub in that respect, we
# switch off the notebook-tests.
RUN_NB_TESTS: "0"

# Determines whether the dev branch ouy are working on shall have a docker image (default 0)
DOCKER_BUILD_MY_BRANCH: "0"
Expand Down

0 comments on commit a02ff48

Please sign in to comment.