Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force xcube Server to open multi-level datasets #1056

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

forman
Copy link
Member

@forman forman commented Aug 6, 2024

  • Changed xcube Server impl. to force opening multi-level datasets.
  • Added schema for "data_type" parameter fro all filesystem data stores

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@forman forman requested a review from konstntokas August 6, 2024 16:17
@forman forman marked this pull request as ready for review August 7, 2024 05:13
Copy link
Contributor

@konstntokas konstntokas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tried to test it on the xcube server demo, but could not recognize any performance increase. Maybe the demo example is too small.

Also, it will be kind of hard to test that "mldataset" is selected, because the output of the function _open_ml_dataset stays the same. Would be interested in how you'd do it.

ml_dataset.ds_id = ds_id

else:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand this is the case for datasets calculated on the fly (in memory). Do we need to take care, that this is done as mldatasets as well, or is this covered already?

@konstntokas konstntokas merged commit 06e46b0 into main Aug 7, 2024
3 checks passed
@konstntokas konstntokas deleted the forman-server_to_require_mldataset branch August 7, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants