labels added, custom cmaps added also if they are not in styles #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
forman
requested changes
Aug 8, 2024
test/util/test_cmaps.py
Outdated
| @@ -403,6 +403,7 @@ def test_create_colormap_from_config_color_entry_object(self): | |||
| "name": "my_cmap", | |||
| "type": "continuous", | |||
| "colors": [[0.0, "red"], [12.0, "#0000FF"], [24.0, [0, 1, 0, 0.3]]], | |||
| "labels": ["low", "medium", "high"], | |||
There was a problem hiding this comment.
That's not correct - at least not what was specified:
type ColorEntryTuple = [number, Color] | [number, Color, label];
See also docs.
There was a problem hiding this comment.
This is the update. Is that okay?
xcube/util/cmaps.py
Outdated
| name=cmap_config["Identifier"], | ||
| type=cmap_config["Type"], | ||
| colors=colors, | ||
| labels=labels, |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1046 second part; see discussion comment and comments below
CHANGES.mdwill not be updated, as it is already updated in #1055.Checklist:
Add docstrings and API docs for any new/modified user-facing classes and functionsdocs/source/*Changes documented inCHANGES.md