Fix test picking up wrong version

xdev-software · Aug 30, 2024 · 9d71170 · 9d71170
1 parent e6541ee
commit 9d71170
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+# 1.0.4
+* Automatic version detection: If multiple versions are found it now uses the "highest" version
+
 # 1.0.3
 * Updated dependencies
 

diff --git a/...ers/src/main/java/software/xdev/testcontainers/mockserver/containers/MockServerUtils.java b/...ers/src/main/java/software/xdev/testcontainers/mockserver/containers/MockServerUtils.java
@@ -17,6 +17,7 @@
 
 import java.io.InputStream;
 import java.net.URL;
+import java.util.Comparator;
 import java.util.Enumeration;
 import java.util.HashSet;
 import java.util.Objects;
@@ -104,7 +105,10 @@ static synchronized String determineClasspathMockserverVersion()
 			return DEFAULT_VERSION;
 		}
 
-		final String foundVersion = versions.iterator().next();
+		// Multiple versions? -> Use highest
+		final String foundVersion = versions.stream()
+			.max(Comparator.naturalOrder())
+			.orElseThrow();
 		if(versions.size() > 1)
 		{
 			LOG.warn(

diff --git a/.../src/test/java/software/xdev/testcontainers/mockserver/containers/MockServerUtilTest.java b/.../src/test/java/software/xdev/testcontainers/mockserver/containers/MockServerUtilTest.java
@@ -25,7 +25,7 @@ class MockServerUtilTest
 	void checkVersionDetection()
 	{
 		Assertions.assertEquals(
-			"1.2.3",
+			"9999.2.3",
 			MockServerUtils.determineClasspathMockserverVersion());
 	}
 }
diff --git a/testcontainers/src/test/resources/META-INF/MANIFEST.MF b/testcontainers/src/test/resources/META-INF/MANIFEST.MF
@@ -1,4 +1,4 @@
 Manifest-Version: 1.0
 
 Name: Mockserver-Info
-Version: 1.2.3
+Version: 9999.2.3