Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for assistant temperature and top_p #788

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Add support for assistant temperature and top_p #788

merged 1 commit into from
Sep 12, 2024

Conversation

realdavidvega
Copy link
Contributor

@realdavidvega realdavidvega commented Sep 12, 2024 •
edited
Loading

Background

We have updated the OpenAI spec, which introduced temperature and top_p settings for the Assistants API.

This PR

Updates Assistant and AssistantRequest to support this configuration by passing the class, or reading the assistant YAML.

The LoadFromYamlConfig example is updated with both temperature and top_p set up.

@realdavidvega realdavidvega self-assigned this Sep 12, 2024
javipacheco
javipacheco approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@javipacheco javipacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@realdavidvega realdavidvega merged commit 0d2574c into main Sep 12, 2024
6 checks passed
@realdavidvega realdavidvega deleted the feature/temperature-top-p branch September 12, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javipacheco javipacheco javipacheco approved these changes

@Montagon Montagon Montagon approved these changes

Assignees

@realdavidvega realdavidvega

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realdavidvega @javipacheco @Montagon