ACC-899 Replace Fabric8 watchers with informers #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgeens
force-pushed
the
fabric8-use-informers
branch
from
934f893
to
c757f7d
Compare
tgeens
force-pushed
the
fabric8-use-informers
branch
from
550c5ae
to
8b428b4
Compare
rschev
reviewed
Jul 28, 2023
| private boolean enabled = false; | ||
| private String namespace = "default"; | ||
| private long resync = 60; |
There was a problem hiding this comment.
That seems fast? We'll always get a bunch of update events that we need to handle every 60s. The Object.equals will handle it early, but still...
There was a problem hiding this comment.
it's worse, I forgot the * 1000L part ;-)
the minimum resync interval is 1 sec - which runs fine locally pointing to a real K8s cluster
Why would once every minute not be fine in production ?
(spring cloud k8s uses 30 secs by default)
rschev
approved these changes
Jul 28, 2023
tgeens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.