Static routing definition for runtime apps, avoiding route refresh #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgeens
commented
Sep 6, 2023
src/test/java/com/contentgrid/gateway/KubernetesServiceDiscoveryIntegrationTest.java
Outdated
Show resolved
Hide resolved
tgeens
force-pushed
the
refresh-routes
branch
2 times, most recently
from
fa80ae0
to
ac17581
Compare
tgeens
force-pushed
the
refresh-routes
branch
2 times, most recently
from
2454e09
to
ec58211
Compare
|
This branch is currently live/deployed on sandbox |
| @Bean | ||
| RouteLocator runtimeAppRouteLocator(RouteLocatorBuilder builder, RuntimeRequestResolver requestResolver) { | ||
| return builder.routes() | ||
| .route(r -> r |
There was a problem hiding this comment.
Couldn't this be a plain gateway configuration file? Something like
That would make it easier to add additional routes that do not forward to a specific application, and makes it easier to configure additional filters when that is necessary
spring:
cloud:
gateway:
routes:
- id: apps
uri: cg://ignored
predicates:
- ResolvesToApplication
filters:
- PreserveHostHeaderIn that case, we would need to explicitly define a ResolvesToApplication gateway predicate, but that's all.
There was a problem hiding this comment.
This could be a static configuration via properties, yes.
- Given that
spring.cloud.gateway.routesis a list, it is imo too easy to overwrite a route-definition by accident - makes runtime integration tests more finicky - now the behaviour is enabled with a single flag
contentgrid.gateway.runtime-platform.enabled: true
This can be revisited in the future.
src/test/java/com/contentgrid/gateway/KubernetesServiceDiscoveryIntegrationTest.java
Outdated
Show resolved
Hide resolved
vierbergenlars
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.