Ship systemd config file for sshpassword support #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasons to have this here include: * don't require changes to srpm when the set of installed files change * make installer development faster by deploying directly to a filesystem This installation process still depends by default on the sm package being installed, but through SM_ROOT variable it can now be run on a dev machine where this is not the case, it just needs an unpacked version of the package. Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
The sshpassword commandline parameter is documented in doc/ but is implemented in this file which was not shipped as part of the installer itself. Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 4, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 6, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 17, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 17, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 18, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 18, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 18, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 19, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Jun 15, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged. Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
ydirson
added a commit
to xcp-ng/create-install-image
that referenced
this pull request
Jun 15, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged. Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
freddy77
reviewed
Dec 8, 2023
Suggested-by: Frediano Ziglio <frediano.ziglio@cloud.com> Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
freddy77
approved these changes
Dec 15, 2023
|
@ydirson I think you should add some reviewers to this PR |
|
@freddy77 I don't think we have enough credentials on this repo for this. |
Added some reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sshpassword commandline parameter is documented in doc/ but
is implemented in this file which was not shipped as part of the
installer itself.
Note this PR builds on #41 to deploy this file automatically in the RPM