Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for build failing due to missing go-vnc #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dongyuzheng
Copy link

Fix for:

dzheng@dzheng-ubuntu-desktop:~/go/src/github.com/xenserver/packer-builder-xenserver$ ./build.sh 
==> Removing old directory...
Number of parallel builds: 7

-->     linux/amd64: github.com/xenserver/packer-builder-xenserver/plugin/builder-xenserver-xva
-->     linux/amd64: github.com/xenserver/packer-builder-xenserver/plugin/builder-xenserver-iso

2 errors occurred:
--> linux/amd64 error: exit status 1
Stderr: builder/xenserver/common/step_type_boot_command.go:7:2: cannot find package "github.com/mitchellh/go-vnc" in any of:
    /home/dzheng/go/src/github.com/xenserver/packer-builder-xenserver/vendor/github.com/mitchellh/go-vnc (vendor tree)
    /usr/local/go/src/github.com/mitchellh/go-vnc (from $GOROOT)
    /home/dzheng/go/src/github.com/mitchellh/go-vnc (from $GOPATH)

--> linux/amd64 error: exit status 1
Stderr: builder/xenserver/common/step_type_boot_command.go:7:2: cannot find package "github.com/mitchellh/go-vnc" in any of:
    /home/dzheng/go/src/github.com/xenserver/packer-builder-xenserver/vendor/github.com/mitchellh/go-vnc (vendor tree)
    /usr/local/go/src/github.com/mitchellh/go-vnc (from $GOROOT)
    /home/dzheng/go/src/github.com/mitchellh/go-vnc (from $GOPATH)

@timoc
Copy link

timoc commented Jul 4, 2017

Does this fix the problem of using xenserver with packer 1.0?

@dongyuzheng
Copy link
Author

I'm not sure what you're referring to. Please be more specific with your problem.

@timoc
Copy link

timoc commented Jul 14, 2017

I've been trying to use packer xen plugin with the packer 1.0 builds without success. not being much of go person i'm having trouble with it. thought this might fix it.

@Vagrantin
Copy link

Hello,
A merge would be welcome because this fix (#60) solve my issue with go-vnc missing.

@dongyuzheng
Copy link
Author

Hi @Vagrantin , please try this fork instead: https://github.com/ctlam/packer-builder-xenserver

@Vagrantin
Copy link

Hi @Vagrantin , please try this fork instead: https://github.com/ctlam/packer-builder-xenserver

Thanks, what is the goal of this fork, you mean this current repo is not maintained anymore ?

@timoc
Copy link

timoc commented Jun 27, 2020

Please review for merge.

@dongyuzheng
Copy link
Author

what is the goal of this fork

Hi @Vagrantin, I was at NVIDIA back in 2016 and we needed some new features / bug fixes to this repo. At the time, I made many Pull Requests, which remain unaddressed to this day.

If you look at the fork history, you'd see that

https://github.com/NVIDIA/packer-builder-xenserver
--> comes from https://github.com/ctlam/packer-builder-xenserver
--> comes from https://github.com/iyyuan/packer-builder-xenserver
--> from my repo https://github.com/dongyuzheng/packer-builder-xenserver
--> from this repo https://github.com/xenserver/packer-builder-xenserver

But https://github.com/ctlam/packer-builder-xenserver is the one most ahead right now, so that is the one I'd recommend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants