Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #93 - context not being set on StepTypeBootCommand #94

Closed
wants to merge 1 commit into from

Conversation

thebinary
Copy link

The issue is due to empty context being set as config.ctx in the builder. So the interpolate function used inside StepTypeBootCommand has no knowledge of the UserVariables.

This commit fixes the issue and so the issue #93

@joncave
Copy link

joncave commented Mar 3, 2018

Just submitted #97 to fix this in a slightly cleaner way by setting the InterpolateContext. This is how the core Hyper-V builder works: https://github.com/hashicorp/packer/blob/master/builder/hyperv/iso/builder.go#L108-L116. The Decode function calls DecodeContext already and will set the context data on the passed InterpolateContext: https://github.com/hashicorp/packer/blob/master/helper/config/decode.go#L45-L48.

@thebinary thebinary closed this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants