Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small improvements to sbt-pack in my fork #83

Open
DavidPerezIngeniero opened this issue Aug 18, 2015 · 3 comments
Open

Some small improvements to sbt-pack in my fork #83

DavidPerezIngeniero opened this issue Aug 18, 2015 · 3 comments

Comments

@DavidPerezIngeniero
Copy link

My need:

To copy *.jar of a webapp called myproject to WEB-INF/lib

The pack task doesn't work because it creates a bin and a lib folders, and other stuff.

I've created a task called packCopyDependencies.
For faster processing and save disk space, I've created a packUseSymbolicLinks, that creates symbolic links instead of copying.

As I want to copy all the dependencies of myproject, but not myproject.jar, I've created the property packExcludeLibJars setting. The original packExclude settings controls both the dependencies of a project and the project.jar. That provides less flexibility.

Luckily, as the code is clean and easy to understand, my modifications have been easy to make.

https://github.com/DavidPerezIngeniero/sbt-pack/blob/develop/src/main/scala/xerial/sbt/Pack.scala

I'll try to correct a previous problem with the checkDuplicatedDependencies task, and make a pull request of all my changes.

@xerial
Copy link
Owner

xerial commented Aug 18, 2015

ok. If possible please make a separate pull request for each change for excluding project.jar and duplicate check.

@DavidPerezIngeniero
Copy link
Author

Sorry, I don't know how to make separate pull requests, and I prefer to spend my limited time to write tests.

@DavidPerezIngeniero
Copy link
Author

I've made the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants