Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check duplicated classes in dependencies tool #65

Merged
merged 7 commits into from
Apr 16, 2015

Conversation

DavidPerezIngeniero
Copy link

I've documented the tool in the README.md file.

At first, I wanted to create an independent plugin, but I've seen later, that it shares many code with your plugin, so I've added the functionality.

Basically I've added one task (checkDuplicatedDependencies) and one setting (checkDuplicatedExclude).

@DavidPerezIngeniero
Copy link
Author

Found this bug: #66

@xerial xerial self-assigned this Mar 26, 2015
@xerial
Copy link
Owner

xerial commented Apr 15, 2015

Sorry. I missed this PR. Will review soon.

@@ -168,6 +169,92 @@ export PATH=$(HOME)/local/bin:$PATH

$ sbt pack-archive

### Find duplicated classes in dependencies
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this explanation is a little bit long for README.md. Could you create a new file (e.g., USAGE.md), then move this section to this file?)

@xerial
Copy link
Owner

xerial commented Apr 15, 2015

Overall, this looks good. Please create USAGE.md for the detailed description of this feature, and add a link to this within README.md

@DavidPerezIngeniero
Copy link
Author

README.md already contains the documentation.

I want to try to improve the performance, by using parallelization.

@DavidPerezIngeniero
Copy link
Author

OK, I'll create a separate file!

@DavidPerezIngeniero
Copy link
Author

Done!

Performance has improved a lot by means of parallelization.

xerial added a commit that referenced this pull request Apr 16, 2015
Check duplicated classes in dependencies tool
@xerial xerial merged commit dfa619e into xerial:develop Apr 16, 2015
@xerial
Copy link
Owner

xerial commented Apr 16, 2015

Merged. Thanks for the contribution!

@xerial
Copy link
Owner

xerial commented May 5, 2015

Here is a link to the broken build: https://travis-ci.org/xerial/sbt-pack/builds/58722323

@DavidPerezIngeniero
Copy link
Author

I'm going to study this problem. It must be easy to fix. I'm not interested in maintaining an own fork.

@DavidPerezIngeniero
Copy link
Author

It seems that this error is due to the parallelization. It makes the behaviour random.
It's a pity because it boosts the performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants