-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check duplicated classes in dependencies tool #65
Conversation
Found this bug: #66 |
Sorry. I missed this PR. Will review soon. |
@@ -168,6 +169,92 @@ export PATH=$(HOME)/local/bin:$PATH | |||
|
|||
$ sbt pack-archive | |||
|
|||
### Find duplicated classes in dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this explanation is a little bit long for README.md. Could you create a new file (e.g., USAGE.md), then move this section to this file?)
Overall, this looks good. Please create USAGE.md for the detailed description of this feature, and add a link to this within README.md |
I want to try to improve the performance, by using parallelization. |
OK, I'll create a separate file! |
Fixed some typos.
Done! Performance has improved a lot by means of parallelization. |
Check duplicated classes in dependencies tool
Merged. Thanks for the contribution! |
Here is a link to the broken build: https://travis-ci.org/xerial/sbt-pack/builds/58722323 |
I'm going to study this problem. It must be easy to fix. I'm not interested in maintaining an own fork. |
It seems that this error is due to the parallelization. It makes the behaviour random. |
I've documented the tool in the README.md file.
At first, I wanted to create an independent plugin, but I've seen later, that it shares many code with your plugin, so I've added the functionality.
Basically I've added one task (checkDuplicatedDependencies) and one setting (checkDuplicatedExclude).