Revert "Check duplicated classes in dependencies tool" #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xerial
added a commit
that referenced
this pull request
May 3, 2015
Revert "Check duplicated classes in dependencies tool"
|
We can open an issue in SBT. If you have enough information you could do it. Otherwise, I'll try to research, when I have free time for this. I haven't observed this behaviour, and my app has over 300 dependencies. |
|
For the investigation please look at TravisCI's logs after mergimg this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #65
@DavidPerezIngeniero
Let me revert this change, since sbt sometimes resolves version conflicts automatically, and sometimes doesn't. So even if there are duplicated jars, the result of
sbt scripted sbt-pack/duplicated-classeswas unstable.If you have any idea on fixing this, please let me know.