Layout Editor: Saving region properties not working (#2771)

relates to xibosignage/xibo#3531
xibosignage · Oct 18, 2024 · a869783 · a869783
1 parent e47fa26
commit a869783
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/ui/src/editor-core/properties-panel.js b/ui/src/editor-core/properties-panel.js
@@ -97,9 +97,8 @@ PropertiesPanel.prototype.save = function(
     target = app.selectedObject;
   }
 
-  // Check if target is playlist
-  const isPlaylist =
-    (target.type === 'region' && target.subType === 'playlist');
+  // Check if target is region
+  const isRegion = target.type === 'region';
 
   // Save original target
   const originalTarget = target;
@@ -167,7 +166,8 @@ PropertiesPanel.prototype.save = function(
     form.find('[name]');
 
   // Filter out position related fields
-  formFieldsToSave = (isPlaylist) ? formFieldsToSave :
+  // if not region
+  formFieldsToSave = (isRegion) ? formFieldsToSave :
     formFieldsToSave.filter('.tab-pane:not(#positionTab) [name]');
 
   // Get form old data
@@ -632,7 +632,7 @@ PropertiesPanel.prototype.render = function(
     // and exit transition
     if (target.type === 'region') {
       const regionType = (target.subType === 'frame') ?
-        'widget' : target.subType;
+        'widgetType' : target.subType;
       dataToRender.regionType = propertiesPanelTrans[regionType];
 
       if (

diff --git a/views/common.twig b/views/common.twig
@@ -686,6 +686,7 @@
                 widgetInfo: {
                     widgetName: "{{ "Widget Name" |trans }}",
                 },
+                widgetType: "{{ "Widget" |trans }}",
                 elementName: "{{ "Element Name" |trans }}",
                 elementNameHelpText: "{{ "An optional name for this element" |trans }}",
                 elementGroupName: "{{ "Element Group Name" |trans }}",