Resolve handling for onTemplateDataLoad and ensure data items are passed correctly #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hook those up on the back end. Fix v3 players isDataReady. Modules: remove old onDataError. relates to xibosignageltd/xibo-private#611
|
TEST: /Layout END |
|
Test Suite: succeeded ✅ |
|
TEST: /Layout END |
|
Test Suite: succeeded ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlayerJS: make sure we pass dataItems into both data load methods and hook those up on the back end.
PlayerJS: Fix v3 players isDataReady.
PlayerJS: call expire now on static widgets where data is not ready
Modules: remove old onDataError.
relates to xibosignageltd/xibo-private#611