Schedule meta and various fixes #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PeterMis
commented
Jul 25, 2023
PeterMis
commented
- Schedule name : relates to xibosignageltd/xibo-private#333
- Schedule meta : relates to Schedule: meta data for created/modified on/by xibo#3051
- Schedule Grid : Fixed Event start/end time representation with user created Dayparts
- Schedule add/edit forms : Fixed Display/groups grouping for Display select
- Schedule Grid : vertical aligned all tds to middle
- Members form (mostly relates to sync group) : Fixed the saving cog icon stuck on save button on error
- Removed schedule-grid-page.twig as we no longer use that (it's all on schedule-page)
…r events with user created dayparts
dasgarner
requested changes
Jul 25, 2023
lib/Controller/Schedule.php
Outdated
| @@ -1696,6 +1697,8 @@ public function edit(Request $request, Response $response, $id) | |||
| $schedule->actionTriggerCode = $sanitizedParams->getString('actionTriggerCode'); | |||
| $schedule->actionLayoutCode = $sanitizedParams->getString('actionLayoutCode'); | |||
| $schedule->maxPlaysPerHour = $sanitizedParams->getInt('maxPlaysPerHour', ['default' => 0]); | |||
| $schedule->name = $sanitizedParams->getString('name'); | |||
| $schedule->modifiedBy = $this->getUser()->userName; | |||
There was a problem hiding this comment.
I think this wants to be userId not userName (which can change)
lib/Entity/Schedule.php
Outdated
| @@ -304,6 +304,30 @@ class Schedule implements \JsonSerializable | |||
| */ | |||
| public $syncGroupId; | |||
|
|
|||
| /** | |||
| * @SWG\Property(description="The userName of the user that last modified this Schedule") | |||
| public function change(): void | ||
| { | ||
| $this->table('schedule') | ||
| ->addColumn('modifiedBy', 'string', ['null' => true, 'default' => null]) |
There was a problem hiding this comment.
integer I think? without a reference to the user table though
dasgarner
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.