Menu Boards: BE, admin and minor widget additions #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- re-enabled admin UI - fix feature checking - fix thumbnail columns/unmatched properties - add product data type - add menu board product widget
- do the same for category
- add calories to product - add description to category - convert price to decimal - translate datatypes - install modules by default
- fix thumbnails - add price element Preview: - pass properties into onElementParseData Weather: - fix issue with element rendering in preview
dasgarner
requested review from
maurofmferrao and
PeterMis
and removed request for
PeterMis and
maurofmferrao
|
I think I'll add some basic filtering before having this reviewed/merged. |
- fix typo in feature check
- add some rules - add "show unavailable" filter
- add display order to product - add sorting, limits - add currency formatting
|
Sorting/filtering has been added. Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation for adding more elements/stencils to the menu board functionality. In this PR I have:
Preview:
onElementParseDataWeather: