Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Prep - 3.3.7 #1949

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Conversation

dasgarner
Copy link
Member

xibosignageltd/xibo-private#372

 - swagger (minor fix)
 - default.pot (minor fix)
 - import latest translations
@dasgarner dasgarner requested a review from PeterMis July 31, 2023 17:08
@dasgarner dasgarner self-assigned this Jul 31, 2023
PeterMis
PeterMis previously approved these changes Jul 31, 2023
Copy link
Member

@PeterMis PeterMis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Minor comment below about odd thing with copyright in php files

@@ -2,7 +2,7 @@
/*
* Copyright (C) 2023 Xibo Signage Ltd
*
* Xibo - Digital Signage - https://xibosignage.com
* Xibo - Digital Signage - http://www.xibo.org.uk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we want to change this 🤔

Given the copyright update in here and in Handlers.php , perhaps it's not quite correctly configured?

@dasgarner dasgarner merged commit 7fc7054 into xibosignage:develop Jul 31, 2023
1 check passed
@dasgarner dasgarner deleted the feature/prep-3.3.7 branch July 31, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants