Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets Preview: player.js refactor with paged elements grouping and effects #1958

Conversation

rubenberttpingol
Copy link
Contributor

relates to xibosignageltd/xibo-private#365

@rubenberttpingol rubenberttpingol self-assigned this Aug 3, 2023
@rubenberttpingol rubenberttpingol marked this pull request as ready for review August 3, 2023 19:37
Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, except 2 minor changes

modules/src/player.js Outdated Show resolved Hide resolved
views/common.twig Show resolved Hide resolved
Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rubenberttpingol rubenberttpingol merged commit 7be7161 into xibosignage:westphal Aug 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants