Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress Test - Schedule #1966

Merged
merged 9 commits into from
Aug 18, 2023

Conversation

ifarzana
Copy link
Contributor

@ifarzana ifarzana commented Aug 7, 2023

@dasgarner
Copy link
Member

dasgarner commented Aug 7, 2023

Before we merge this and it gets into a release, we need to find a way to remove access to these special "test only" routes in the main release files. I think the way we do that is have them in a separate file called routes-cypress.php which we include from routes.php only if it exists.

We can then delete the routes-cypress.php from inside the production Dockerfile, meaning they won't be available in the main build.

This PR can wait until after rc1 on that basis.

@ifarzana ifarzana self-assigned this Aug 15, 2023
@dasgarner
Copy link
Member

We can then delete the routes-cypress.php from inside the production Dockerfile, meaning they won't be available in the main build.

I don't see this in the updated PR - did it get done?

@ifarzana
Copy link
Contributor Author

I don't see this in the updated PR - did it get done?

my mistake, that's added now.

@ifarzana ifarzana merged commit 5941127 into xibosignage:westphal Aug 18, 2023
1 of 2 checks passed
@ifarzana ifarzana deleted the feature/cypress_schedule branch August 18, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants