Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMDS font fixes & duration/numItems #1973

Merged
merged 7 commits into from
Aug 9, 2023
Merged

XMDS font fixes & duration/numItems #1973

merged 7 commits into from
Aug 9, 2023

Conversation

dasgarner
Copy link
Member

@dasgarner dasgarner commented Aug 8, 2023 •
edited
Loading

Fixed:

  • downloads for fonts via XMDS/CDN
  • property validation of the default value, and conditions which use the value in the condition for the test
  • numItems for dataset/calendar xibosignageltd/xibo-private#394

@dasgarner dasgarner self-assigned this Aug 8, 2023
@dasgarner dasgarner marked this pull request as ready for review August 8, 2023 11:09
@dasgarner dasgarner requested a review from ifarzana August 8, 2023 11:10
@dasgarner dasgarner changed the title XMDS font fixes XMDS font fixes & duration/numItems Aug 9, 2023
maurofmferrao
maurofmferrao approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dasgarner dasgarner merged commit f25757e into xibosignage:westphal Aug 9, 2023
1 of 2 checks passed
@dasgarner dasgarner deleted the westphal/cloud-theme branch August 9, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurofmferrao maurofmferrao maurofmferrao approved these changes

@ifarzana ifarzana Awaiting requested review from ifarzana

Assignees

@dasgarner dasgarner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dasgarner @maurofmferrao