Minor misc fixes #1986
Merged
Minor misc fixes #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xibo/xibosignage#3079
xibo/xibosignage#3080
… and Display Groups grids. xibo/xibosignage#2927
dasgarner
requested changes
Aug 15, 2023
lib/Service/PlayerActionService.php
Outdated
| throw new InvalidArgumentException(__('This Player is not configured or ready to receive push commands over XMR. Please contact your administrator.'), 'xmrRegistered'); | ||
| if ($display->xmrChannel == '' || $display->xmrPubKey == '') { | ||
| throw new InvalidArgumentException( | ||
| __(sprintf( |
There was a problem hiding this comment.
This needs to be the other way around sprintf(__())
lib/Service/PlayerActionService.php
Outdated
|
|
||
| $displayAction = clone $action; | ||
|
|
||
| try { | ||
| $displayAction->setIdentity($display->xmrChannel, $display->xmrPubKey); | ||
| } catch (\Exception $exception) { | ||
| throw new InvalidArgumentException(__('Invalid XMR registration'), 'xmrPubKey'); | ||
| throw new InvalidArgumentException( | ||
| __(sprintf( |
| throw new ConfigurationException(sprintf(__('%d of %d player actions failed'), $failures, count($this->actions))); | ||
| if ($failures > 0) { | ||
| throw new ConfigurationException( | ||
| sprintf( |
There was a problem hiding this comment.
This one is the right way around 😄
dasgarner
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Selectedto execute command xibo#2927