Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes 10 #2011

Merged
merged 10 commits into from
Aug 25, 2023
Merged

Misc fixes 10 #2011

merged 10 commits into from
Aug 25, 2023

Conversation

dasgarner
Copy link
Member

@dasgarner dasgarner commented Aug 25, 2023 •
edited
Loading

Peter:

  • Widget cache: too many files were building up, so they are cleared daily
  • Help links: adjustments after testing
  • Regions to have an empty name by default
  • Broken connectors (installed but no class) shouldn't show

Mauro:

  • Uploader shouldn't show view library
  • Modules/Module Templates can have an icon
  • Swap to use fa classes directly
  • Convert all elements to use icons

@dasgarner dasgarner self-assigned this Aug 25, 2023
maurofmferrao
maurofmferrao approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dasgarner dasgarner merged commit 3d86abb into xibosignage:westphal Aug 25, 2023
2 checks passed
@dasgarner dasgarner deleted the westphal/misc_fixes_10 branch August 25, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurofmferrao maurofmferrao maurofmferrao approved these changes

@PeterMis PeterMis PeterMis approved these changes

Assignees

@dasgarner dasgarner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dasgarner @PeterMis @maurofmferrao