Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Elements and Weather fixes #2021

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

dasgarner
Copy link
Member

Implement required elements in the BE so that the "attribution" element must be provided when adding Weather. Also fixes for the weather icons not being included.

@dasgarner dasgarner self-assigned this Aug 30, 2023
@dasgarner
Copy link
Member Author

phpcs is on unchanged lines, won't fix.

Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dasgarner dasgarner merged commit 48a9b0e into xibosignage:westphal Aug 30, 2023
0 of 2 checks passed
@dasgarner dasgarner deleted the westphal/required_elements branch August 30, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants