From 70b221cedff0b08c3ef2725f037997a8c904d515 Mon Sep 17 00:00:00 2001
From: Dan Garner <dan@xibosignage.com>
Date: Fri, 9 Feb 2024 16:06:00 +0000
Subject: [PATCH 1/2] PlayerJS: make sure we pass dataItems into both data load
 methods and hook those up on the back end. Fix v3 players isDataReady.
 Modules: remove old onDataError. relates to xibosignageltd/xibo-private#611

---
 lib/Entity/Module.php                    |  8 +--
 lib/Entity/ModuleTemplate.php            |  8 ++-
 lib/Factory/ModuleFactory.php            |  7 +--
 lib/Factory/ModuleTemplateFactory.php    |  8 ++-
 lib/Widget/Render/WidgetHtmlRenderer.php |  9 +--
 modules/calendar.xml                     | 13 +---
 modules/src/xibo-player.js               | 80 ++++++++++++++++--------
 modules/widget-html-render.twig          | 12 ++--
 8 files changed, 82 insertions(+), 63 deletions(-)

diff --git a/lib/Entity/Module.php b/lib/Entity/Module.php
index 7710adcb82..9b75b0e6e5 100644
--- a/lib/Entity/Module.php
+++ b/lib/Entity/Module.php
@@ -1,6 +1,6 @@
 <?php
 /*
- * Copyright (C) 2023 Xibo Signage Ltd
+ * Copyright (C) 2024 Xibo Signage Ltd
  *
  * Xibo - Digital Signage - https://xibosignage.com
  *
@@ -203,12 +203,6 @@ class Module implements \JsonSerializable
      */
     public $onDataLoad;
 
-    /**
-     * @SWG\Property(description="An error function to run when the widget is unable to fetch data")
-     * @var string
-     */
-    public $onDataError;
-
     /**
      * @SWG\Property(description="JavaScript function run when a module is rendered, after data has been returned")
      * @var string
diff --git a/lib/Entity/ModuleTemplate.php b/lib/Entity/ModuleTemplate.php
index f1b40417e8..461ab7c5b5 100644
--- a/lib/Entity/ModuleTemplate.php
+++ b/lib/Entity/ModuleTemplate.php
@@ -1,6 +1,6 @@
 <?php
 /*
- * Copyright (C) 2023 Xibo Signage Ltd
+ * Copyright (C) 2024 Xibo Signage Ltd
  *
  * Xibo - Digital Signage - https://xibosignage.com
  *
@@ -130,6 +130,12 @@ class ModuleTemplate implements \JsonSerializable
      */
     public $assets;
 
+    /**
+     * @SWG\Property(description="A load function to run when the template first fetches data")
+     * @var string
+     */
+    public $onTemplateDataLoad;
+
     /** @var string A Renderer to run if custom rendering is required. */
     public $onTemplateRender;
 
diff --git a/lib/Factory/ModuleFactory.php b/lib/Factory/ModuleFactory.php
index ff8816cade..faecaf4d7c 100644
--- a/lib/Factory/ModuleFactory.php
+++ b/lib/Factory/ModuleFactory.php
@@ -1,6 +1,6 @@
 <?php
 /*
- * Copyright (C) 2023 Xibo Signage Ltd
+ * Copyright (C) 2024 Xibo Signage Ltd
  *
  * Xibo - Digital Signage - https://xibosignage.com
  *
@@ -706,11 +706,6 @@ private function createFromXml(string $file, array $modulesWithSettings): Module
             $module->onDataLoad = trim($module->onDataLoad);
         }
 
-        $module->onDataError = $this->getFirstValueOrDefaultFromXmlNode($xml, 'onDataError');
-        if (!empty($module->onDataError)) {
-            $module->onDataError = trim($module->onDataError);
-        }
-
         $module->onRender = $this->getFirstValueOrDefaultFromXmlNode($xml, 'onRender');
         if (!empty($module->onRender)) {
             $module->onRender = trim($module->onRender);
diff --git a/lib/Factory/ModuleTemplateFactory.php b/lib/Factory/ModuleTemplateFactory.php
index 35b6fb453e..233b16afc9 100644
--- a/lib/Factory/ModuleTemplateFactory.php
+++ b/lib/Factory/ModuleTemplateFactory.php
@@ -1,6 +1,6 @@
 <?php
 /*
- * Copyright (C) 2023 Xibo Signage Ltd
+ * Copyright (C) 2024 Xibo Signage Ltd
  *
  * Xibo - Digital Signage - https://xibosignage.com
  *
@@ -232,10 +232,16 @@ private function createFromXml(\DOMElement $xml): ModuleTemplate
         $template->startHeight = intval($this->getFirstValueOrDefaultFromXmlNode($xml, 'startHeight'));
         $template->hasDimensions = $this->getFirstValueOrDefaultFromXmlNode($xml, 'hasDimensions', 'true') === 'true';
         $template->canRotate = $this->getFirstValueOrDefaultFromXmlNode($xml, 'canRotate', 'false') === 'true';
+        $template->onTemplateDataLoad = $this->getFirstValueOrDefaultFromXmlNode($xml, 'onTemplateDataLoad');
         $template->onTemplateRender = $this->getFirstValueOrDefaultFromXmlNode($xml, 'onTemplateRender');
         $template->onTemplateVisible = $this->getFirstValueOrDefaultFromXmlNode($xml, 'onTemplateVisible');
         $template->onElementParseData = $this->getFirstValueOrDefaultFromXmlNode($xml, 'onElementParseData');
         $template->showIn = $this->getFirstValueOrDefaultFromXmlNode($xml, 'showIn') ?? 'both';
+
+        if (!empty($template->onTemplateDataLoad)) {
+            $template->onTemplateDataLoad = trim($template->onTemplateDataLoad);
+        }
+
         if (!empty($template->onTemplateRender)) {
             $template->onTemplateRender = trim($template->onTemplateRender);
         }
diff --git a/lib/Widget/Render/WidgetHtmlRenderer.php b/lib/Widget/Render/WidgetHtmlRenderer.php
index f384475889..0fefe53145 100644
--- a/lib/Widget/Render/WidgetHtmlRenderer.php
+++ b/lib/Widget/Render/WidgetHtmlRenderer.php
@@ -397,8 +397,8 @@ private function render(
         $twig['onRender'] = [];
         $twig['onParseData'] = [];
         $twig['onDataLoad'] = [];
-        $twig['onDataError'] = [];
         $twig['onElementParseData'] = [];
+        $twig['onTemplateDataLoad'] = [];
         $twig['onTemplateRender'] = [];
         $twig['onTemplateVisible'] = [];
         $twig['onInitialize'] = [];
@@ -522,9 +522,6 @@ private function render(
             if (!empty($module->onDataLoad)) {
                 $twig['onDataLoad'][$widget->widgetId] = $module->onDataLoad;
             }
-            if (!empty($module->onDataError)) {
-                $twig['onDataError'][$widget->widgetId] = $module->onDataError;
-            }
             if (!empty($module->onRender)) {
                 $twig['onRender'][$widget->widgetId] = $module->onRender;
             }
@@ -733,6 +730,10 @@ private function render(
                 $twig['style'][] = $moduleTemplate->stencil->style;
             }
 
+            if ($moduleTemplate->onTemplateDataLoad !== null) {
+                $twig['onTemplateDataLoad'][$moduleTemplate->templateId] = $moduleTemplate->onTemplateDataLoad;
+            }
+
             if ($moduleTemplate->onTemplateRender !== null) {
                 $twig['onTemplateRender'][$moduleTemplate->templateId] = $moduleTemplate->onTemplateRender;
             }
diff --git a/modules/calendar.xml b/modules/calendar.xml
index 35ddd17016..65da8d1f38 100644
--- a/modules/calendar.xml
+++ b/modules/calendar.xml
@@ -1,5 +1,5 @@
 <!--
-  ~ Copyright (C) 2023 Xibo Signage Ltd
+  ~ Copyright (C) 2024 Xibo Signage Ltd
   ~
   ~ Xibo - Digital Signage - https://xibosignage.com
   ~
@@ -179,17 +179,6 @@
             <default></default>
         </property>
     </properties>
-    <onDataError><![CDATA[
-    if (typeof httpStatus === 'undefined' || typeof response === 'undefined') {
-        return false;
-    }
-
-    var hasSucceed = response.hasOwnProperty('success') && response.success === true;
-
-    if (!hasSucceed) {
-        return false;
-    }
-]]></onDataError>
     <onDataLoad><![CDATA[
 // items: The items to render
 // meta: Metadata
diff --git a/modules/src/xibo-player.js b/modules/src/xibo-player.js
index 769bfe2a5d..fb447a5e0d 100644
--- a/modules/src/xibo-player.js
+++ b/modules/src/xibo-player.js
@@ -45,22 +45,29 @@ const XiboPlayer = function() {
           method: 'GET',
           url: currentWidget.url,
         }).done(function(data) {
+          // The contents of the JSON file will be an object with data and meta
           resolve({
             ...data,
-            onDataReady: true,
+            isDataReady: true,
           });
         }).fail(function(jqXHR, textStatus, errorThrown) {
           console.log(jqXHR, textStatus, errorThrown);
           resolve({
-            onDataReady: false,
+            isDataReady: false,
             error: jqXHR.status,
             success: false,
             data: jqXHR.responseJSON,
           });
         });
       } else if (currentWidget.data?.data !== undefined) {
-        resolve(currentWidget.data);
+        // This happens for v3 players where the data is already
+        // added to the HTML
+        resolve({
+          ...currentWidget.data,
+          isDataReady: true,
+        });
       } else {
+        // This should be impossible.
         resolve(null);
       }
     });
@@ -80,28 +87,31 @@ const XiboPlayer = function() {
     let widgetDataItems = [];
     let shouldShowError = false;
     let withErrorMessage = null;
-    let isDataReady = null;
 
     if (isDataWidget) {
-      const {dataItems, showError, errorMessage, onDataReady} =
+      const {dataItems, showError, errorMessage} =
           this.loadData(playerWidget, data);
       widgetDataItems = dataItems;
       shouldShowError = showError;
       withErrorMessage = errorMessage;
-      isDataReady = onDataReady;
     }
 
-    playerWidget.onDataReady = isDataReady;
+    playerWidget.isDataReady = data?.isDataReady || false;
     playerWidget.meta = data !== null ? data?.meta : {};
     playerWidget.items = [];
 
+    // Decorate this widget with all applicable functions
     this.loadWidgetFunctions(playerWidget, widgetDataItems);
 
     if (isDataWidget) {
-      const templateDataState = playerWidget.onTemplateDataLoad();
+      const templateDataState =
+        playerWidget.onTemplateDataLoad(widgetDataItems);
+
+      widgetDataItems = templateDataState.dataItems;
+      console.log('onTemplateDataLoad::widgetDataItems ', widgetDataItems);
 
       if (!templateDataState.handled) {
-        const dataLoadState = playerWidget.onDataLoad();
+        const dataLoadState = playerWidget.onDataLoad(widgetDataItems);
         console.log(
           'onTemplateDataLoad::handled = ', templateDataState.handled);
 
@@ -184,9 +194,8 @@ const XiboPlayer = function() {
   /**
    * Define widget functions used for render flow
    * @param {Object} playerWidget Widget object
-   * @param {Array} dataItems Widget data
    */
-  this.loadWidgetFunctions = function(playerWidget, dataItems) {
+  this.loadWidgetFunctions = function(playerWidget) {
     const self = this;
     const params = this.getRenderParams(
       playerWidget,
@@ -194,21 +203,26 @@ const XiboPlayer = function() {
       globalOptions,
     );
 
-    playerWidget.onTemplateDataLoad = function() {
+    playerWidget.onTemplateDataLoad = function(widgetDataItems) {
       return self.onTemplateDataLoad({
         widgetId: playerWidget.widgetId,
+        dataItems: widgetDataItems,
+        meta: playerWidget.meta,
+        properties: playerWidget.properties,
+        isDataReady: playerWidget.isDataReady,
       });
     };
-    playerWidget.onDataLoad = function() {
+    playerWidget.onDataLoad = function(widgetDataItems) {
       return self.onDataLoad({
         widgetId: playerWidget.widgetId,
-        dataItems,
+        dataItems: widgetDataItems,
         meta: playerWidget.meta,
         properties: playerWidget.properties,
+        isDataReady: playerWidget.isDataReady,
       });
     };
     playerWidget.onParseData = function(widgetDataItems) {
-      return self.onParseData(playerWidget, widgetDataItems ?? dataItems);
+      return self.onParseData(playerWidget, widgetDataItems);
     };
     playerWidget.onTemplateRender = function(currentWidget, options) {
       return self.onTemplateRender(
@@ -717,7 +731,7 @@ XiboPlayer.prototype.isEditor = function() {
 };
 
 /**
- * Compose widget data
+ * Show sample data or an error if in the editor.
  * @param {Object} currentWidget Widget object
  * @param {Object|Array} data Widget data from data provider
  * @return {Object} widgetData
@@ -728,7 +742,6 @@ XiboPlayer.prototype.loadData = function(currentWidget, data) {
     isSampleData: false,
     dataItems: [],
     isArray: Array.isArray(data?.data),
-    onDataReady: data?.onDataReady,
     showError: false,
     errorMessage: null,
   };
@@ -903,6 +916,12 @@ XiboPlayer.prototype.renderStaticWidget = function(staticWidget) {
     $target.append($errMsg);
   }
 
+  // Expire if the data is not ready
+  if (!staticWidget.isDataReady) {
+    console.error('static widget where data is not ready, expiring');
+    xiboIC.expireNow({targetId: xiboICTargetId});
+  }
+
   // Add meta to the widget if it exists
   if (data?.meta) {
     staticWidget.meta = data.meta;
@@ -1418,29 +1437,37 @@ XiboPlayer.prototype.onTemplateDataLoad = function(params) {
       window['onTemplateDataLoad_' + params.widgetId];
   }
 
-  let onTemplateDataLoadRes = {handled: false};
+  let onTemplateDataLoadResponse =
+    {handled: false, dataItems: params.dataItems ?? []};
 
   if (onTemplateDataLoad) {
-    const onTemplateDataLoadResult = onTemplateDataLoad(params.widgetId);
+    const onTemplateDataLoadResult = onTemplateDataLoad(
+      params.dataItems,
+      params.meta,
+      params.properties,
+      params.isDataReady,
+    );
 
     if (onTemplateDataLoadResult !== undefined &&
       Object.keys(onTemplateDataLoadResult).length > 0
     ) {
       if ((onTemplateDataLoadResult ?? {}).hasOwnProperty('handled')) {
-        onTemplateDataLoadRes = {
-          ...onTemplateDataLoadRes,
+        onTemplateDataLoadResponse = {
+          ...onTemplateDataLoadResponse,
           handled: onTemplateDataLoadResult.handled,
         };
-      } else {
-        onTemplateDataLoadRes = {
-          ...onTemplateDataLoadResult,
-          ...onTemplateDataLoadRes,
+      }
+
+      if ((onTemplateDataLoadResult ?? {}).hasOwnProperty('dataItems')) {
+        onTemplateDataLoadResponse = {
+          ...onTemplateDataLoadResponse,
+          dataItems: onTemplateDataLoadResult.dataItems,
         };
       }
     }
   }
 
-  return onTemplateDataLoadRes;
+  return onTemplateDataLoadResponse;
 };
 
 /**
@@ -1464,6 +1491,7 @@ XiboPlayer.prototype.onDataLoad = function(params) {
       params.dataItems,
       params.meta,
       params.properties,
+      params.isDataReady,
     );
 
     if (onDataLoadResult !== undefined &&
diff --git a/modules/widget-html-render.twig b/modules/widget-html-render.twig
index 826603c116..38a74128d5 100644
--- a/modules/widget-html-render.twig
+++ b/modules/widget-html-render.twig
@@ -114,16 +114,16 @@
       }
     </script>
 {% endfor %}
-{% for widgetId, parser in onDataLoad %}
-    <script type="text/javascript" id="onDataLoad-{{ widgetId }}">
-      function onDataLoad_{{ widgetId }}(items, meta, properties) {
+{% for widgetId, parser in onTemplateDataLoad %}
+    <script type="text/javascript" id="onTemplateDataLoad-{{ widgetId }}">
+      function onTemplateDataLoad_{{ widgetId }}(items, meta, properties, isDataReady) {
         {{ parser|raw }}
       }
     </script>
 {% endfor %}
-{% for widgetId, parser in onDataError %}
-    <script type="text/javascript" id="onDataError-{{ widgetId }}">
-      function onDataError_{{ widgetId }}(httpStatus, response) {
+{% for widgetId, parser in onDataLoad %}
+    <script type="text/javascript" id="onDataLoad-{{ widgetId }}">
+      function onDataLoad_{{ widgetId }}(items, meta, properties, isDataReady) {
         {{ parser|raw }}
       }
     </script>

From 31d23d8f5c59985bc4017683f15b1f88674d1ad8 Mon Sep 17 00:00:00 2001
From: Dan Garner <dan@xibosignage.com>
Date: Fri, 9 Feb 2024 16:35:40 +0000
Subject: [PATCH 2/2] PlayerJS: remove onTemplateData load as unnecessary.

relates to xibosignageltd/xibo-private#611
---
 lib/Entity/ModuleTemplate.php            |  6 --
 lib/Factory/ModuleTemplateFactory.php    |  5 --
 lib/Widget/Render/WidgetHtmlRenderer.php |  5 --
 modules/src/xibo-player.js               | 83 ++----------------------
 modules/widget-html-render.twig          |  7 --
 5 files changed, 6 insertions(+), 100 deletions(-)

diff --git a/lib/Entity/ModuleTemplate.php b/lib/Entity/ModuleTemplate.php
index 461ab7c5b5..c9532bef4b 100644
--- a/lib/Entity/ModuleTemplate.php
+++ b/lib/Entity/ModuleTemplate.php
@@ -130,12 +130,6 @@ class ModuleTemplate implements \JsonSerializable
      */
     public $assets;
 
-    /**
-     * @SWG\Property(description="A load function to run when the template first fetches data")
-     * @var string
-     */
-    public $onTemplateDataLoad;
-
     /** @var string A Renderer to run if custom rendering is required. */
     public $onTemplateRender;
 
diff --git a/lib/Factory/ModuleTemplateFactory.php b/lib/Factory/ModuleTemplateFactory.php
index 233b16afc9..36284cddb9 100644
--- a/lib/Factory/ModuleTemplateFactory.php
+++ b/lib/Factory/ModuleTemplateFactory.php
@@ -232,16 +232,11 @@ private function createFromXml(\DOMElement $xml): ModuleTemplate
         $template->startHeight = intval($this->getFirstValueOrDefaultFromXmlNode($xml, 'startHeight'));
         $template->hasDimensions = $this->getFirstValueOrDefaultFromXmlNode($xml, 'hasDimensions', 'true') === 'true';
         $template->canRotate = $this->getFirstValueOrDefaultFromXmlNode($xml, 'canRotate', 'false') === 'true';
-        $template->onTemplateDataLoad = $this->getFirstValueOrDefaultFromXmlNode($xml, 'onTemplateDataLoad');
         $template->onTemplateRender = $this->getFirstValueOrDefaultFromXmlNode($xml, 'onTemplateRender');
         $template->onTemplateVisible = $this->getFirstValueOrDefaultFromXmlNode($xml, 'onTemplateVisible');
         $template->onElementParseData = $this->getFirstValueOrDefaultFromXmlNode($xml, 'onElementParseData');
         $template->showIn = $this->getFirstValueOrDefaultFromXmlNode($xml, 'showIn') ?? 'both';
 
-        if (!empty($template->onTemplateDataLoad)) {
-            $template->onTemplateDataLoad = trim($template->onTemplateDataLoad);
-        }
-
         if (!empty($template->onTemplateRender)) {
             $template->onTemplateRender = trim($template->onTemplateRender);
         }
diff --git a/lib/Widget/Render/WidgetHtmlRenderer.php b/lib/Widget/Render/WidgetHtmlRenderer.php
index 0fefe53145..42d4f33039 100644
--- a/lib/Widget/Render/WidgetHtmlRenderer.php
+++ b/lib/Widget/Render/WidgetHtmlRenderer.php
@@ -398,7 +398,6 @@ private function render(
         $twig['onParseData'] = [];
         $twig['onDataLoad'] = [];
         $twig['onElementParseData'] = [];
-        $twig['onTemplateDataLoad'] = [];
         $twig['onTemplateRender'] = [];
         $twig['onTemplateVisible'] = [];
         $twig['onInitialize'] = [];
@@ -730,10 +729,6 @@ private function render(
                 $twig['style'][] = $moduleTemplate->stencil->style;
             }
 
-            if ($moduleTemplate->onTemplateDataLoad !== null) {
-                $twig['onTemplateDataLoad'][$moduleTemplate->templateId] = $moduleTemplate->onTemplateDataLoad;
-            }
-
             if ($moduleTemplate->onTemplateRender !== null) {
                 $twig['onTemplateRender'][$moduleTemplate->templateId] = $moduleTemplate->onTemplateRender;
             }
diff --git a/modules/src/xibo-player.js b/modules/src/xibo-player.js
index fb447a5e0d..8245160f39 100644
--- a/modules/src/xibo-player.js
+++ b/modules/src/xibo-player.js
@@ -104,29 +104,14 @@ const XiboPlayer = function() {
     this.loadWidgetFunctions(playerWidget, widgetDataItems);
 
     if (isDataWidget) {
-      const templateDataState =
-        playerWidget.onTemplateDataLoad(widgetDataItems);
+      const dataLoadState = playerWidget.onDataLoad(widgetDataItems);
+      console.log('onDataLoad::handled = ', dataLoadState.handled);
 
-      widgetDataItems = templateDataState.dataItems;
-      console.log('onTemplateDataLoad::widgetDataItems ', widgetDataItems);
+      widgetDataItems = dataLoadState.dataItems;
 
-      if (!templateDataState.handled) {
-        const dataLoadState = playerWidget.onDataLoad(widgetDataItems);
-        console.log(
-          'onTemplateDataLoad::handled = ', templateDataState.handled);
-
-        widgetDataItems = dataLoadState.dataItems;
-        console.log('dataLoadState::widgetDataItems ', widgetDataItems);
-
-        if (!dataLoadState.handled) {
-          console.log('onDataLoad::handled = ', dataLoadState.handled);
-          widgetDataItems = playerWidget.onParseData(widgetDataItems);
-          console.log('onParseData::widgetDataItems ', widgetDataItems);
-        }
-      } else {
-        console.log(
-          'onTemplateDataLoad::handled = ', templateDataState.handled);
-        widgetDataItems = playerWidget.onParseData();
+      if (!dataLoadState.handled) {
+        widgetDataItems = playerWidget.onParseData(widgetDataItems);
+        console.log('onParseData::widgetDataItems ', widgetDataItems);
       }
     }
 
@@ -203,15 +188,6 @@ const XiboPlayer = function() {
       globalOptions,
     );
 
-    playerWidget.onTemplateDataLoad = function(widgetDataItems) {
-      return self.onTemplateDataLoad({
-        widgetId: playerWidget.widgetId,
-        dataItems: widgetDataItems,
-        meta: playerWidget.meta,
-        properties: playerWidget.properties,
-        isDataReady: playerWidget.isDataReady,
-      });
-    };
     playerWidget.onDataLoad = function(widgetDataItems) {
       return self.onDataLoad({
         widgetId: playerWidget.widgetId,
@@ -1423,53 +1399,6 @@ XiboPlayer.prototype.isModule = function(currentWidget) {
     (!currentWidget.isDataExpected && this.inputElements.length === 0);
 };
 
-/**
- * Caller function for onTemplateDataLoad
- * @param {Object} params
- * @return {Object} State to determine next step. E.g. {handled: false}
- */
-XiboPlayer.prototype.onTemplateDataLoad = function(params) {
-  let onTemplateDataLoad = null;
-  // onTemplateDataLoad function should be checked and run first before
-  if (typeof window['onTemplateDataLoad_' + params.widgetId] ===
-    'function') {
-    onTemplateDataLoad =
-      window['onTemplateDataLoad_' + params.widgetId];
-  }
-
-  let onTemplateDataLoadResponse =
-    {handled: false, dataItems: params.dataItems ?? []};
-
-  if (onTemplateDataLoad) {
-    const onTemplateDataLoadResult = onTemplateDataLoad(
-      params.dataItems,
-      params.meta,
-      params.properties,
-      params.isDataReady,
-    );
-
-    if (onTemplateDataLoadResult !== undefined &&
-      Object.keys(onTemplateDataLoadResult).length > 0
-    ) {
-      if ((onTemplateDataLoadResult ?? {}).hasOwnProperty('handled')) {
-        onTemplateDataLoadResponse = {
-          ...onTemplateDataLoadResponse,
-          handled: onTemplateDataLoadResult.handled,
-        };
-      }
-
-      if ((onTemplateDataLoadResult ?? {}).hasOwnProperty('dataItems')) {
-        onTemplateDataLoadResponse = {
-          ...onTemplateDataLoadResponse,
-          dataItems: onTemplateDataLoadResult.dataItems,
-        };
-      }
-    }
-  }
-
-  return onTemplateDataLoadResponse;
-};
-
 /**
  * Caller function for onDataLoad
  * @param {Object} params
diff --git a/modules/widget-html-render.twig b/modules/widget-html-render.twig
index 38a74128d5..d9ac8ec142 100644
--- a/modules/widget-html-render.twig
+++ b/modules/widget-html-render.twig
@@ -114,13 +114,6 @@
       }
     </script>
 {% endfor %}
-{% for widgetId, parser in onTemplateDataLoad %}
-    <script type="text/javascript" id="onTemplateDataLoad-{{ widgetId }}">
-      function onTemplateDataLoad_{{ widgetId }}(items, meta, properties, isDataReady) {
-        {{ parser|raw }}
-      }
-    </script>
-{% endfor %}
 {% for widgetId, parser in onDataLoad %}
     <script type="text/javascript" id="onDataLoad-{{ widgetId }}">
       function onDataLoad_{{ widgetId }}(items, meta, properties, isDataReady) {