Layout: sync together canvas and layout sharing. #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterMis
approved these changes
Feb 29, 2024
|
TEST: all |
|
Test Suite: failed ❌ |
|
TEST: all |
|
Test Suite: failed ❌ |
ifarzana
approved these changes
Mar 7, 2024
|
I am going to test this locally because it seems the container cannot be built, possibly because this PR predates our test pipeline (the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating layout sharing should update any Canvas regions with the same. Adding a new canvas region should adopt the layout sharing that already exists. A double-lock.
In addition, trying to set canvas permissions separately will throw an error (@maurofmferrao I think you will remove that option once this is merged?)