Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display alerts #2482

Merged
merged 10 commits into from
Apr 18, 2024
Merged

Display alerts #2482

merged 10 commits into from
Apr 18, 2024

Conversation

PeterMis
Copy link
Member

@PeterMis PeterMis requested a review from dasgarner April 11, 2024 12:35
@PeterMis PeterMis self-assigned this Apr 11, 2024
@ifarzana
Copy link
Contributor

TEST: all

@github-actions GitHub Actions
Copy link

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/8702195978

ifarzana
ifarzana approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@ifarzana ifarzana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get latest PR container

@PeterMis PeterMis requested a review from ifarzana April 16, 2024 15:35
ifarzana
ifarzana approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ifarzana ifarzana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to build PR container

@ifarzana
Copy link
Contributor

TEST: all

@github-actions GitHub Actions
Copy link

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/8737924100

@ifarzana
Copy link
Contributor

TEST: /Reporting/report_bandwidth.cy.js, /Reporting/report_proofofplay.cy.js, /Reporting/report_timeconnectedsummary.cy.js, /Schedule/schedule.cy.js END

@github-actions GitHub Actions
Copy link

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/8738111043

@ifarzana
Copy link
Contributor

TEST: /Reporting/report_bandwidth.cy.js END

@github-actions GitHub Actions
Copy link

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/8739919168

@ifarzana
Copy link
Contributor

TEST: /Reporting/report_proofofplay.cy.js END

@github-actions GitHub Actions
Copy link

Test Suite: succeeded ✅
https://github.com/xibosignage/xibo-cms/actions/runs/8739982898

ifarzana
ifarzana approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ifarzana ifarzana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to build

@ifarzana
Copy link
Contributor

TEST: /Reporting/report_bandwidth.cy.js, /Reporting/report_timeconnectedsummary.cy.js, /Schedule/schedule.cy.js END

@github-actions GitHub Actions
Copy link

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/8740303676

@PeterMis PeterMis merged commit 722211b into giacobini Apr 18, 2024
2 of 3 checks passed
@PeterMis PeterMis deleted the feature/giacobini_display_alerts branch April 18, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasgarner dasgarner dasgarner approved these changes

@ifarzana ifarzana ifarzana approved these changes

Assignees

@PeterMis PeterMis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterMis @ifarzana @dasgarner